Please let CC to support the global namepace

[Loaden]

Code Select Expand

#include <iostream>
#include <windows.h>

using namespace std;

int main()
{
   ::Mess // HERE，no-work. if not use global namespace, it's work fine.
   return 0;
}

I try to add a rule, and adding this rules, and CB not start now.

Code Select Expand

<::>
<![CDATA[]]>
</::>

[blueshake]

Patch for it.

Code Select Expand

Index: src/plugins/codecompletion/nativeparser.cpp
===================================================================
--- src/plugins/codecompletion/nativeparser.cpp (revision 6089)
+++ src/plugins/codecompletion/nativeparser.cpp (working copy)
@@ -1638,9 +1638,9 @@
             }
             Manager::Get()->GetLogManager()->DebugLog(F(_T("BreakUpComponents() Found component: '%s' (%s)"), tok.wx_str(), tokenTypeString.wx_str()));
         }
+        if (tok.Length() != 0 || tokenType == pttSearchText)
+            components.push(pc);

-        components.push(pc);
-
         if (tokenType == pttSearchText)
             break;
     }


see the screen shot.
welcome to test it.

[attachment deleted by admin]

[Loaden]

Yes, it works well Thank you very much!
But there is a small problem, see the picture prompts.


[attachment deleted by admin]

[Loaden]

All other tests are good.

[attachment deleted by admin]

[blueshake]

ok,I will continue to improve it.

[MortenMacFly]

Patch for it.
[...]
welcome to test it.

Nice one. Can you do me a favor (for the future) and comment such changes? It's not very clear in the first place what the if statement actually means. Thanks! :-)

[MortenMacFly]

I try to add a rule, and adding this rules, and CB not start now.

Code Select Expand

<::>
<![CDATA[]]>
</::>

You do know how often "::" appears in C++ code (e.g. MyClass::MyMethod)?! ;-)

[blueshake]

well.

it mean nothing if the tokenType  is not pttSearchText.

for example:

for global codecompletion,such codes:

::abc

when we type these codes,the search will break the texts(::abc) into two compesents.

one is "" ,type is pttNameSpace
another is "abc" ,type is pttSearchText.

[blueshake]

continue my comment.

so for pttNameSpace type ,if its text(tok) is empty.we need to eat this component.that is why the statement  tok.Length() != 0 in the if condition.
but for pttSearchText type ,we can not do this.because for such search codes(ss:: ),so we need another statement tokenType == pttSearchText in the if condition too.

[ollydbg]

continue my comment.

so for pttNameSpace type ,if its text(tok) is empty.we need to eat this component.that is why the statement  tok.Length() != 0 in the if condition.
but for pttSearchText type ,we can do this.because for such search codes(ss:,so we need another statement tokenType == pttSearchText in the if condition too.

So, you mean: if we breakUP this statement"::abc".
We should result only One ParserComponent. right?

[blueshake]

yes,only abc should be keeped.so the cc will work like global search.

[blueshake]

@Loaden

can you try this patch and give me feedback?

Is  this issue still there?

But there is a small problem, see the picture prompts.

patch:

Code Select Expand

Index: src/plugins/codecompletion/nativeparser.cpp
===================================================================
--- src/plugins/codecompletion/nativeparser.cpp (revision 6089)
+++ src/plugins/codecompletion/nativeparser.cpp (working copy)
@@ -1638,9 +1638,9 @@
             }
             Manager::Get()->GetLogManager()->DebugLog(F(_T("BreakUpComponents() Found component: '%s' (%s)"), tok.wx_str(), tokenTypeString.wx_str()));
         }
+        if (!tok.IsEmpty() || (tokenType == pttSearchText && components.size() != 0))
+            components.push(pc);

-        components.push(pc);
-
         if (tokenType == pttSearchText)
             break;
     }


[Loaden]

@Loaden

can you try this patch and give me feedback?

Is  this issue still there?

But there is a small problem, see the picture prompts.

patch:

Code Select Expand

Index: src/plugins/codecompletion/nativeparser.cpp
===================================================================
--- src/plugins/codecompletion/nativeparser.cpp (revision 6089)
+++ src/plugins/codecompletion/nativeparser.cpp (working copy)
@@ -1638,9 +1638,9 @@
             }
             Manager::Get()->GetLogManager()->DebugLog(F(_T("BreakUpComponents() Found component: '%s' (%s)"), tok.wx_str(), tokenTypeString.wx_str()));
         }
+        if (!tok.IsEmpty() || (tokenType == pttSearchText && components.size() != 0))
+            components.push(pc);

-        components.push(pc);
-
         if (tokenType == pttSearchText)
             break;
     }


It's OK now! perfect!

[attachment deleted by admin]

[blueshake]

@Loaden

can you try this patch and give me feedback?

Is  this issue still there?

But there is a small problem, see the picture prompts.

patch:

Code Select Expand

Index: src/plugins/codecompletion/nativeparser.cpp
===================================================================
--- src/plugins/codecompletion/nativeparser.cpp (revision 6089)
+++ src/plugins/codecompletion/nativeparser.cpp (working copy)
@@ -1638,9 +1638,9 @@
             }
             Manager::Get()->GetLogManager()->DebugLog(F(_T("BreakUpComponents() Found component: '%s' (%s)"), tok.wx_str(), tokenTypeString.wx_str()));
         }
+        if (!tok.IsEmpty() || (tokenType == pttSearchText && components.size() != 0))
+            components.push(pc);

-        components.push(pc);
-
         if (tokenType == pttSearchText)
             break;
     }


@morten

seems you don't apply this patch correctly,so in current cc, when you type "(" ,cc will give a lot of wrong tips.can you check this??

[MortenMacFly]

seems you don't apply this patch correctly,so in current cc, when you type "(" ,cc will give a lot of wrong tips.can you check this??

Work fine here...?! What exactly do you mean? Remember that this is just for global namespace. IIRC we had discussed this. So that's why it is as it is now.