After merged with trunk (scintilla branch to trunk).
Any comment?
Quote from: Loaden on September 16, 2010, 05:29:26 AM
Any comment?
This is true... I didn't realise this so far... However, the modifications are actually not related to the CC Kick-In Windows at all?! Weired...?!
This patch fixes it for me, but this code was not changed in the update, so I don't know what has happened.
--- tmp/tmpFZA7Cp-meld/PlatWX.cpp
+++ home/jens/codeblocks-build/codeblocks.pure.trunk/src/sdk/wxscintilla/src/PlatWX.cpp
@@ -828,7 +828,7 @@
SetBackgroundColour(*wxBLACK); // for our simple border
lv = new wxSCIListBox(parent, id, wxDefaultPosition, wxDefaultSize,
- wxLC_REPORT | wxLC_SINGLE_SEL | wxLC_NO_HEADER | wxBORDER_NONE);
+ wxLC_REPORT | wxLC_SINGLE_SEL | wxLC_NO_HEADER | wxSIMPLE_BORDER);
lv->SetCursor(wxCursor(wxCURSOR_ARROW));
lv->InsertColumn(0, wxEmptyString);
lv->InsertColumn(1, wxEmptyString);
@@ -954,7 +954,7 @@
{
lv = new wxSCIListBox(this, id, wxDefaultPosition, wxDefaultSize,
- wxLC_REPORT | wxLC_SINGLE_SEL | wxLC_NO_HEADER | wxNO_BORDER);
+ wxLC_REPORT | wxLC_SINGLE_SEL | wxLC_NO_HEADER | wxSIMPLE_BORDER);
lv->SetCursor(wxCursor(wxCURSOR_ARROW));
lv->InsertColumn(0, wxEmptyString);
lv->InsertColumn(1, wxEmptyString);
Quote from: jens on September 16, 2010, 01:12:34 PM
This patch fixes it for me, but this code was not changed in the update, so I don't know what has happened.
Jens, you are the hero. I was looking inside the lower-level Scintilla code for long, but found nothing. Then I had to skip. I'll look into the changes again to see why this is needed suddenly... Please commit! :-)
Quote from: MortenMacFly on September 16, 2010, 06:56:13 PM
Quote from: jens on September 16, 2010, 01:12:34 PM
This patch fixes it for me, but this code was not changed in the update, so I don't know what has happened.
Jens, you are the hero. I was looking inside the lower-level Scintilla code for long, but found nothing. Then I had to skip. I'll look into the changes again to see why this is needed suddenly... Please commit! :-)
Done (trunk r6601), I also added the ability to change fore- and background-color of CallTips ("stolen" from ScintillaBase and slightly modified).
Quote from: jens on September 16, 2010, 10:26:11 PM
Done (trunk r6601), I also added the ability to change fore- and background-color of CallTips ("stolen" from ScintillaBase and slightly modified).
Thanks. I had a look again at your changes. In fact, isn't it weird that the border had been there until now? I mean: If I got your changes right, then it was set implicitly to
wxBORDER_NONE, was it?! So the actual question is why this was
visible in the past... :shock:
However, it's back to "normal" now luckily.
Nice! works well now.( I just merged from trunk to cc branch manual. )
@Morten, could you merge the changes from trunk to cc branch?
Thanks!