Rectangle copy/paste and drag/drop is completely broken in wxScintilla. This patch fixes the copy/paste. The patch applies to rev.1499 in codeblocks/src. If you give me rev 1500 I will be :lol: :lol:
http://sourceforge.net/tracker/index.php?func=detail&aid=1290351&group_id=126998&atid=707416
If you want to set the svn:author field too, "sam" is great.
Quote
Topic: Rectangle copy and paste bugfixes
Description:
! Fix rectangle copy and paste (ticket:1290351)
Sam
Edit: Don't use this patch. The one in post 3 is cumulative and is a better fix (includes the fix for drag/drop).[attachment deleted by admin]
As everyone knows, C::B uses wxScintilla for the actual text editor. The buzz I'm hearing so far is no one wants to make changes to the C::B copy since they would be hard to integrate with future releases of wxScintilla.
I have identified a few bugs with the editor itself, and fixed one "big one" so far. IMO, a bug in a subproject is a bug in C::B, and should be fixed like any other bug. I would be happy to work on the scintilla section of C::B, including bugfixes and incorporating new releases of wxScintilla into C::B as they are available.
So that's all I'm asking really. Please don't turn down bug fixes just because you aren't the original creator of a module. :(
Thanks,
Sam :)
Quote from: Urxae on December 14, 2005, 01:15:58 AM
I'm guessing wxScintilla has a bug/patch tracker somewhere. Don't forget to send bug reports and/or the patches to fix bugs there, so others can fix the bugs and benefit from the patches. Bonus: the C::B copy diverges less from the 'official' version (assuming patches are accepted), so it'll be less work to maintain.
Thanks. I went ahead and posted a patch for this on the wxCode sourceforge page. :)
This patch takes the place of the first one.Both copy/paste and drag/drop work in this one. :)
The patch applies to rev.1506 in codeblocks/src.
Quote
Topic: Rectangle copy and paste bugfixes
Description:
! Fix rectangle copy and paste (ticket:1290351)
! Fix rectangle drag and drop
[attachment deleted by admin]
Cool! :) What's that ticket for, by the way?
Quote from: rickg22 on December 14, 2005, 06:31:07 AM
Cool! :) What's that ticket for, by the way?
Sourceforge bug ID
When you use Trac, if you put ticket:#### it automatically replaces it with a link to the bug report, so I'm used to that format. Here is an example:
http://djss.dynalias.net/trac/LS2FireMod/log/?action=stop_on_copy&rev=51&stop_rev=&mode=stop_on_copy&verbose=on
I see... anyway mind submitting your patch to the wxScintilla project too?
Also, I don't know if i should be the one evaluating / applying your patch. Yiannis? Anyone?
I think the correct way would be to only submit it to wxScintilla. But it won't do much harm applying it to Code::Blocks either.
That way, we can just keep updating releases like we have done before. I don't think keeping our own private copy around is any good, unless we absolutely have to for some good reason.
wxScintilla has made some changes to the CVS on sourceforge already, so I made a patch based on their code (different from our copy) and posted it there yesterday.
https://sourceforge.net/tracker/?func=detail&atid=462818&aid=1379992&group_id=51305