void MainFrame::SetupDebuggerUI()
{
m_debuggerMenuHandler = new DebuggerMenuHandler;
m_debuggerToolbarHandler = new DebuggerToolbarHandler(m_debuggerMenuHandler);
m_debuggerMenuHandler->SetEvtHandlerEnabled(false);
m_debuggerToolbarHandler->SetEvtHandlerEnabled(false);
wxWindow* window = Manager::Get()->GetAppWindow();
if (window)
{
window->PushEventHandler(m_debuggerMenuHandler);
window->PushEventHandler(m_debuggerToolbarHandler);
}
m_debuggerMenuHandler->SetEvtHandlerEnabled(true);
m_debuggerToolbarHandler->SetEvtHandlerEnabled(true);
....
Question: I can't find there is a place to "delete m_debuggerMenuHandler", does it mean the wxwidgets framework can delete it? Or there is memory leak?
Quote from: ollydbg on April 17, 2013, 02:36:58 AM
Or there is memory leak?
Just a memory leak. wxWidgets deletes only window type of object, I suppose.
I'll take care of it.
Fev 8995 fix one memory leak(m_debuggerMenuHandler), what about m_debuggerToolbarHandler?
Quote from: ollydbg on April 18, 2013, 04:04:03 PM
Fev 8995 fix one memory leak(m_debuggerMenuHandler), what about m_debuggerToolbarHandler?
Fix it the same way.
Quote from: oBFusCATed on April 18, 2013, 05:05:25 PM
Quote from: ollydbg on April 18, 2013, 04:04:03 PM
Fev 8995 fix one memory leak(m_debuggerMenuHandler), what about m_debuggerToolbarHandler?
Fix it the same way.
I fixed it in rev 8998.