Text only | Text with Images

Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Development => Topic started by: tomay3000 on October 01, 2019, 09:53:58 PM

Title: wxSmith Settings - One radio button is in the wrong group!
Post by: tomay3000 on October 01, 2019, 09:53:58 PM
Hello,

I think that the radio button, illustrated in the attached screenshot is in the wrong group.

Thank you.
Title: Re: wxSmith Settings - One radio button is in the wrong group!
Post by: Miguel Gimenez on October 02, 2019, 10:32:13 AM
Good catch.

The attached patch fixes this. The solution is just adding the wxRB_GROUP flag to one of the radio buttons, but the patch has grown a lot due to wxSmith sorting things. It also changed automatically FlexGridSizer1->Add(0,0,1, wxEXPAND, 5) to FlexGridSizer1->Add(-1,-1,1, wxEXPAND, 5), and this moved the radio buttons to the left.

EDIT: the moving of radio buttons is fixed in the next message's patch
Title: Re: wxSmith Settings - One radio button is in the wrong group!
Post by: Miguel Gimenez on October 02, 2019, 12:24:49 PM
This revised patch fixes the original issue and radio buttons moving to the left in the bottom line.
Title: Re: wxSmith Settings - One radio button is in the wrong group!
Post by: tomay3000 on October 02, 2019, 10:10:38 PM
Thank you, I will try it later.
If it has been applied to svn trunk, I will simply update my local clone, and recompile it.
Title: Re: wxSmith Settings - One radio button is in the wrong group!
Post by: BlueHazzard on October 03, 2019, 11:43:18 AM
Can you please create a ticket?
I will look into the wxSmith things today...
Title: Re: wxSmith Settings - One radio button is in the wrong group!
Post by: Miguel Gimenez on October 03, 2019, 12:46:52 PM
Ticket 875:

https://sourceforge.net/p/codeblocks/tickets/875/

EDIT: can you take a look to the patch in ticket 845?
Text only | Text with Images