Print Page - wxSmith ArtProvider/Toolbar issue (patch submitted)

Title: wxSmith ArtProvider/Toolbar issue (patch submitted)
Post by: rj-away on September 17, 2007, 09:08:09 AM

I'm not sure if the usual protocol is to provide notice about submitted patches here or not but I recently submitted a patch (http://developer.berlios.de/patch/?func=detailpatch&patch_id=2166&group_id=5358) to fix a non-critical but real bug (http://developer.berlios.de/bugs/?func=detailbug&bug_id=11934&group_id=5358) in some of the handling of ArtProvider stuff for Toolbars. This patch "seemed to work fine for me^tm".

Title: Re: wxSmith ArtProvider/Toolbar issue (patch submitted)
Post by: byo on September 18, 2007, 09:01:23 PM

Thanks for the patch. I haven't had much time to investigate it before but from what I've seen your solution (maybe not only inside wxToolbar but in wxBitmapIconProperty) is correct.

Regards
BYO

Title: Re: wxSmith ArtProvider/Toolbar issue (patch submitted)
Post by: byo on September 18, 2007, 10:01:04 PM

Ok, I've fixed that (little bit different from your). It worked for me but since I don't have debug wxWidges library I can't be sure. Could you test if the fix works ?

BYO

Title: Re: wxSmith ArtProvider/Toolbar issue (patch submitted)
Post by: rj-away on September 24, 2007, 03:57:02 AM

Thank you byo, that seems to have solved the core issue with the wxArtProvider stuff.

One side issue, though, is that the #include for <wx/artprov.h> isn't being generated in the resulting cpp code.

Code::Blocks Forums

Developer forums (C::B DEVELOPMENT STRICTLY!) => Plugins development => Topic started by: rj-away on September 17, 2007, 09:08:09 AM