News:

As usual while waiting for the next release - don't forget to check the nightly builds in the forum.

Main Menu

3 localization plugin patches

Started by gd_on, September 16, 2013, 07:11:55 PM

Previous topic - Next topic

gd_on

3 small patches for localizing 3 plugins.

gd_on
Windows 11 64 bits (25H2), svn C::B (last version or almost!), wxWidgets 3.3.2, Msys2 Compilers 16.1.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\msys64\mingw64) or 32 bits (dwarf2, posix  in C:\msys64\mingw32).

oBFusCATed

All 5 are in svn. Next time please use a single topic and a more descriptive topic names if possible.

Thank you for the contribution.
Can I ask you to provide a patch which adds you to the "help -> about -> thanks to" dialog?
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

gd_on

QuoteCan I ask you to provide a patch which adds you to the "help -> about -> thanks to" dialog?
Why not, but my contributions are weak until now  :-\
Here is a new patch, complementary from a previous one (I forgot it yesterday  :-[).

gd_on
Windows 11 64 bits (25H2), svn C::B (last version or almost!), wxWidgets 3.3.2, Msys2 Compilers 16.1.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\msys64\mingw64) or 32 bits (dwarf2, posix  in C:\msys64\mingw32).

oBFusCATed

This patch won't be applied, because it tries to translate string that are commented or part of the output of cvs, which is not good.
I've also remove these parts from the other patch, too.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

gd_on

QuoteThis patch won't be applied, because it tries to translate string that are commented or part of the output of cvs, which is not good.
Sorry. I didn't thought this may be a problem. I just prepared for an eventual future translation if the lines were uncommented. Sorry again.

gd_on
Windows 11 64 bits (25H2), svn C::B (last version or almost!), wxWidgets 3.3.2, Msys2 Compilers 16.1.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\msys64\mingw64) or 32 bits (dwarf2, posix  in C:\msys64\mingw32).

gd_on

Here is a corrected version : no translation in comments.
Hope it's OK now.

gd_on
Windows 11 64 bits (25H2), svn C::B (last version or almost!), wxWidgets 3.3.2, Msys2 Compilers 16.1.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\msys64\mingw64) or 32 bits (dwarf2, posix  in C:\msys64\mingw32).

MortenMacFly

Quote from: gd_on on September 20, 2013, 11:39:33 AM
Hope it's OK now.
I am not sure. The code you've patched is parses the output of a cvs command after calling the cvs executable. If you localise it, the parser is broken. I think in this file there really is nothing else to localise.
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: [url="https://www.codeblocks.org/docs/main_codeblocks_en.html"]https://www.codeblocks.org/docs/main_codeblocks_en.html[/url]
C::B FAQ: [url="https://wiki.codeblocks.org/index.php?title=FAQ"]https://wiki.codeblocks.org/index.php?title=FAQ[/url]

gd_on

Sorry, but I don't understand what do you mean by "output of a cvs command".
On my PC, it works perfectly. Strings are translated as they should be and nothing seems to be broken: menus works as expected. Without this patch, they still appear in English.

gd_on
Windows 11 64 bits (25H2), svn C::B (last version or almost!), wxWidgets 3.3.2, Msys2 Compilers 16.1.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\msys64\mingw64) or 32 bits (dwarf2, posix  in C:\msys64\mingw32).

oBFusCATed

He is talking about this change:

@@ -1798,17 +1798,17 @@
         VCSstate s;
         while(1)
         {
-            if(state==_T("Up-to-date"))
+            if(state==_("Up-to-date"))
             {
                 s.state=fvsVcUpToDate;
                 break;
             }
-            if(state==_T("Locally Modified"))
+            if(state==_("Locally Modified"))
             {
                 s.state=fvsVcModified;
                 break;
             }
-            if(state==_T("Locally Added"))
+            if(state==_("Locally Added"))
             {
                 s.state=fvsVcAdded;
                 break;


Can you try without it?
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

gd_on

#9
OK, I see now. Effectively it's not correct.
The problem now is that when I create a patch with Tortoise svn, I have some problems: I can't relly revert to the previous svn version, the one completly in english.
I tried to revert to a previous svn number, to delete the file, ... each time my previous modifications are still there and I'm not sure that the patch is correct. Strange!
I miss something ! ???

But may be I have nothing to do now because my errors have been corrected !

gd_on
Windows 11 64 bits (25H2), svn C::B (last version or almost!), wxWidgets 3.3.2, Msys2 Compilers 16.1.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\msys64\mingw64) or 32 bits (dwarf2, posix  in C:\msys64\mingw32).

oBFusCATed

"svn revert file_path" should do it, if I remember correctly. I think there was a menu command, too.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]