News:

The new Release 25.03 is out! You can download binaries for Windows and many major Linux distros here .

Main Menu

another patch for the todo plugin

Started by frithjofh, November 20, 2015, 01:46:11 PM

Previous topic - Next topic

frithjofh

updated a dialogue to be more user friendly. refactored. added some security checks

changes to the asktypedlg gui :

- replaced the combobox with a list of radiobuttons

changes to the asktypedlg.h :

- changed base class to wxDialog
- changed constructor to take argumnts by const&
- made destructor virtual

changes to the asktypedlg.cpp :

- changed base class to wxDialog
- changed constructor to take arguments by const&
- in constructor added some checks for the XRC system
- moved empty destructor to header
- did the according changes caused by change of gui
- some clean up
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

frithjofh

included the list of changes made in the previous post
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

ollydbg

Quote from: frithjofh on November 20, 2015, 01:46:11 PM

changes to the asktypedlg.h :

- changed base class to wxDialog
...
- changed base class to wxDialog
...
I haven't test your patch, but looked a the patch file, I see the above changes. My question is why you change to wxDialog?
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

frithjofh

let me return the question: why should it be a wxScrolledDialog?

is that needed by anybody or by anything? I couldn't tell, so I chose the more simple alternative.

if there is a reason for wxScrolledDialog here, please tell me, and I'll switch back.

thx for the feedback  :)
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

Jenna

Quote from: frithjofh on November 24, 2015, 08:15:22 PM
let me return the question: why should it be a wxScrolledDialog?

is that needed by anybody or by anything? I couldn't tell, so I chose the more simple alternative.

if there is a reason for wxScrolledDialog here, please tell me, and I'll switch back.

thx for the feedback  :)
wxScrollDialog automatically uses scrollbars, if the dialog does not fit on screen.

frithjofh

yes, I know that much, but the dialog is really tiny...

maybe on a mobile phone...
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100