Files order in virtual folders

[oBFusCATed]

Please post a real patch. 

[earlgrey]

Not for the moment, I am working on
- my externel lexer loader for scintilla ( which works but will never be accepted by Neil )
- my enhanced OpenFilesList plugin

http://www.mediafire.com/view/qawkuoi05ac8qvu/2015.08.20-cb%20LexerExt%20OFL.png#

[earlgrey]

trunk@svn10640 - ProjectTreeSortChildrenRecursive()@ProjectManagerUI.cpp : remove the red part and it is ok

static void ProjectTreeSortChildrenRecursive(cbTreeCtrl* tree, const wxTreeItemId& parent)
{
    wxTreeItemIdValue cookie = nullptr;

    tree->SortChildren(parent);

    wxTreeItemId current = tree->GetFirstChild(parent, cookie);
    while (current && tree->ItemHasChildren(current))
    {
        ProjectTreeSortChildrenRecursive(tree, current);
        current = tree->GetNextChild(parent, cookie);
    }
}

It breaks the recursion traveling ; current may not have children, but may have brothers :

while (...) loop : 

                                  current ( = first child )
                                      |
                   +------------------------------------+
                   |                                    |
            has children                      dont have children
                   |                                    |
                   v                                    v
    - recursion on current's children    - missing loop on current's brothers
    - loop on current's brothers

You may put the optimization test on 'sterile' nodes inside the while (...) loop. Or code a recurse process differently.

[oBFusCATed]

I guess you're proposing a fix for the original issue, right?
Can you post a tested patch?  :

[earlgrey]

Here it is, I did

Code Select Expand

diff -au projectmanagerui.cpp@10648 projectmanagerui.cpp@earlgrey > projectmanagerui.cpp.patch
so you patch with

Code Select Expand

patch projectmanagerui.cpp projectmanagerui.cpp.patch
I :
* added an optimization at method begin
* moved the misplaced original one.
-> bye bye, bug

[MortenMacFly]

Here it is, I did

Code Select Expand

diff -au projectmanagerui.cpp@10648 projectmanagerui.cpp@earlgrey > projectmanagerui.cpp.patch

This won't work on Windows (easily). Can you please just use SVN to create a patch file as suggested?
In your SVN working copy, please run: this command:
svn diff > my.patch

[oBFusCATed]

BTW: Morten have you tried to install git bash? It contains most of the unix tools, so it might have a working version of the patch tool.

[MortenMacFly]

BTW: Morten have you tried to install git bash? It contains most of the unix tools, so it might have a working version of the patch tool.

Sure and not only that, so I think I have plenty of versions of "patch", but you don't really want me to go to the command line on Windows, just to apply a patch, right? What frustrates me is that there is an easy way using SVN to create and apply patches, but we get them in so many different formats and for each format I need a special tool. I remember that previously even "patch" was not "patch" but you needed a special version...

Oh it could be that simple...  ;D

[earlgrey]

Here it is

Code Select Expand


$ cd codeblocks-code
$ svn diff > projectmanagerui.cpp@10668.svn-diff.patch


[earlgrey]

I see patch has not been yet applied ; If you are afraid of modifying core C::B's UI with not-well-tested patch, you shouldn't : bug was only a small inattention error.

[oBFusCATed]

In svn after some cleanup and simplification. Thanks.