Right-Click unselects highlighted text

[RJP Computing]

I am using Windows XP SP2 and Code::Blocks version 1.0-RC2.

When you right-click after highlighting text it gets unselected. This basically makes the 'Edit' menu items useless. eg. Cut and Copy.

- Ryan

[rickg22]

This seems to be a bug. Please report it at sourceforge.

Thanks!

[rickg22]

OK, i see it reported as bug #1342953.
http://sourceforge.net/tracker/index.php?func=detail&aid=1342953&group_id=126998&atid=707416

I'd appreciate it if any of the devs would give us a hand with this. I'll try to pinpoint the bug, but I'm not sure I can find it.

[thomas]

Fixed.


EDIT:
The fix has the side effect that you have to select a word before you can use "Find declaration of..." (but that is the lesser evil).
The best solution will probably be to check whether there is currently a selection and whether the click is inside that selection. Otherwise, proceed as before. I haven't figured that yet, though.
Another solution (a lot easier) would be to rewrite "Find declaration of..." to use the click position rather than the cursor position. Not good, don't have mouse position available at that time.

EDIT 2:
Done that, too. Right-click in selection keeps selection. Right-click outside selection behaves as before. Guess that can be considered final now.

[mandrav]

Thanks Thomas

[rickg22]

Thanks a lot! What sourcefiles did you change? Did you update the sourceforge bug?

[thomas]

What sourcefiles did you change?

cbEditor.h:

Code Select Expand


bool cbEditor::OnBeforeBuildContextMenu(bool noeditor)
{
     if (!noeditor)
     {
         cbStyledTextCtrl* control = Manager::Get()->GetEditorManager()->....
         int pos = control->PositionFromPoint(control->ScreenToClient(wxGetMousePosition()));
-        control->GotoPos(pos);
+        if(control->GetSelectionStart() > pos || control->GetSelectionEnd() < pos)
+            control->GotoPos(pos);
     }
...
}

Did you update the sourceforge bug?

Uhh.... no admin rights?

[rickg22]

You just have to be logged in. I gave you technician privileges, so you can close the bug and mark it "fixed".

Edit: Hmmm... Thomas just send me a screenshot. Are *only* admins allowed to change bugs' status? (I closed the bug anyway)