Projectlayoutloader improvement and changes to editor zooming (patch to test)

[Jenna]

This thread shows me that editor-zooming does not work consistently.

The current implementation saves the last seen zoom-factor and uses it for all newly opened editors, except for the second control in split-view.
Editors that have been opened are not zoomed automatically.

In my opinion, zooming should either only affect the editor, that has the focus, or all editors (egally whether they are opened or not).

I attach a a patch, that does exact this (configurable via "Settings -> Editor... -> Other options -> Zooming resizes all editors").
Additionally it saves the zoom-factor and the split-state on a per editor base in the project layout file.

The patch is against trunk and conflicts with my mousewheel/double-click/etc-patch (http://forums.next.codeblocks.org/index.php/topic,13826.msg94108.html#msg94108).

As always tester and comments/improvements/whishes ... are welcome.

Tested on debian 64-bit and winXP.

EDIT:
updated patch: http://forums.next.codeblocks.org/index.php/topic,14027.msg94324.html#msg94324

[UberNewb]

As always tester and comments/improvements/whishes ... are welcome.

May I suggest that when the user changes their font size in the menu, that it resets the zoom level of all the editors to zero? Not resetting the zoom level upon menu font size changes led to quite a bit of confusion on my part because at one point I had zoomed in the editor and this led to split editors opening up in a different font size than I thought was actually set in the menu.

[Jenna]

As always tester and comments/improvements/whishes ... are welcome.

May I suggest that when the user changes their font size in the menu, that it resets the zoom level of all the editors to zero? Not resetting the zoom level upon menu font size changes led to quite a bit of confusion on my part because at one point I had zoomed in the editor and this led to split editors opening up in a different font size than I thought was actually set in the menu.

Done in the attached patch.
It's configurable via checkbox below the sample text in editor config-dialog.

[MortenMacFly]

Done in the attached patch.

This patch conflicts with the other of yours on (minimise space) my system. For the sake of easier testing (and if it doesn't cause too much overhead) is it possible that you generate a combined patch?

[Jenna]

Done in the attached patch.

This patch conflicts with the other of yours on (minimise space) my system. For the sake of easier testing (and if it doesn't cause too much overhead) is it possible that you generate a combined patch?

I can do this (it needs some manual applied changes, because both patches touch cbAuiNotebook), and I will do.
The combined patch will aso have some more nullpointer checks in cbAuiNotebbok  :wink: .

Comes (most likely) this evening.

[Jenna]

Done in the attached patch.

This patch conflicts with the other of yours on (minimise space) my system. For the sake of easier testing (and if it doesn't cause too much overhead) is it possible that you generate a combined patch?

I can do this (it needs some manual applied changes, because both patches touch cbAuiNotebook), and I will do.
The combined patch will aso have some more nullpointer checks in cbAuiNotebbok  :wink: .

Comes (most likely) this evening.

Combines the patch attached here (http://forums.next.codeblocks.org/index.php/topic,13826.msg94108.html#msg94108) and the one from above (http://forums.next.codeblocks.org/index.php/topic,14027.msg94324.html#msg94324) plus some more nullpointer checks to (hopefully) get rid of some crashes occured on windows.

It's against trunk and will (most likely) not apply on debugger-branch, but should work for wxSmith-addons-branch.

EDIT:
Updated patch: http://forums.next.codeblocks.org/index.php/topic,14027.msg94568.html#msg94568

[Jenna]

Updated patch against current trunk , should also apply in debugger-branch.

Do you experience any issues so far ?

Can/should it be applied to trunk ?

EDIT:

Patch updated: http://forums.next.codeblocks.org/index.php/topic,13826.msg94704.html#msg94704

[oBFusCATed]

Jens, I'm lost in your changes...
please commit them...

The scrolling of tabs with the mouse was working last time I've checked (it was the opposite direction, but it was working (I prefer the same as FF)).
The closing problem was fixed, it was working OK.

If there are problems you can fix them in svn

p.s. I stopped testing when the two patches where merged...

[Jenna]

Jens, I'm lost in your changes...

So I am  :?

What I want to know, if there are basic objections from other devs, because the patch(es) change the sdk and the behaviour of (some small parts) of C::B.

[MortenMacFly]

What I want to know, if there are basic objections from other devs, because the patch(es) change the sdk and the behaviour of (some small parts) of C::B.

From my point of view - having tested the previous (so not the one you are referring to here) combined patch - it works very well, also all crashed I had experienced are gone now.

I'd vote for (if possible) apply both changes in trunk, but having two commits... (as I said: if possible).

[Jenna]

What I want to know, if there are basic objections from other devs, because the patch(es) change the sdk and the behaviour of (some small parts) of C::B.

From my point of view - having tested the previous (so not the one you are referring to here) combined patch - it works very well, also all crashed I had experienced are gone now.

I'd vote for (if possible) apply both changes in trunk, but having two commits... (as I said: if possible).

The actual patch is the same, it only reflects two changes to trunk, that break applying it.

I will split it into two parts, but I don't know if I find the time before the next week.

[MortenMacFly]

I will split it into two parts, but I don't know if I find the time before the next week.

No problem. Have a nice weekend!

[Jenna]

Patch updated: http://forums.next.codeblocks.org/index.php/topic,13826.msg94704.html#msg94704

[Jenna]

Applied to trunk svn r6935 !