ConfigManager editor bugs

[takeshimiya]

Hi! It seems that the new ConfigManager will requiere
heavy testing. I've just noticed in latest CVS some bugs:

The first, the colors chosed in
Settings->Editor->Colors gets screwed up when saved to
the xml.

Here's the patch:
In sdk/configmanager.cpp at line 694, change
ret->Set(r, b, g);
to
ret->Set(r, g, b);


The second, the <UNDERLINED bool="0" /> doesn't get
saved in some cases.

Take for example in C/C++ the Matching Brace Highlight.
Bold and Italic seems to get saved right, but despite you set to off the Underlined, it doesn't even get writted to the xml.
It gets writted if Underlined=1 though.

I suppose the bug is in some Save function from sdk/editorcolorset.cpp.

Hope this helps!

[mandrav]

Hopefully, I 've fixed them all earlier today.
Thanks

[takeshimiya]

 

[Urxae]

The second, the <UNDERLINED bool="0" /> doesn't get
saved in some cases.

Take for example in C/C++ the Matching Brace Highlight.
Bold and Italic seems to get saved right, but despite you set to off the Underlined, it doesn't even get writted to the xml.
It gets writted if Underlined=1 though.

I suppose the bug is in some Save function from sdk/editorcolorset.cpp.

Hopefully, I 've fixed them all earlier today.
Thanks

If that one's fixed, feel free to close this bugreport I filed for it.

Now excuse me while I recompile from CVS and finally turn the bloody matching brace underline OFF .

[takeshimiya]

Oops, I didn't noticed that bug report.

BTW, I compiled recently the CVS and now I get zero syntax highlighting for any language. I hope this is because anon CVS lags.
I wonder if anonymous SVN from BerliOS will lag too...

[Urxae]

BTW, I compiled recently the CVS and now I get zero syntax highlighting for any language. I hope this is because anon CVS lags.

Yes, I have the same problem. But I was able to turn off the underlining and put back the old C::B version (I archived it). Now as long as I don't touch the settings it should stay un-underlined .

I wonder if anonymous SVN from BerliOS will lag too...

I think the lag is a Sourceforge-only thing. High traffic loads and such. Not sure though.

[mandrav]

BTW, I compiled recently the CVS and now I get zero syntax highlighting for any language. I hope this is because anon CVS lags.

Unfortunately not. I uncommented one line and didn't notice a typo in there, result of a copy-paste when converting to new ConfigManager, which caused this.
Fixed now in CVS.
I also fixed resetting colors to defaults. It would reset colors for all languages instead for the selected only (as is hinted by the question message box).

[Urxae]

By the way, is there any way it can remember which language I had last selected and open that one when the dialog is created? It's rather annoying to have to switch from AngelScript to C/C++ every time, when that's all I program in lately.

[mandrav]

By the way, is there any way it can remember which language I had last selected and open that one when the dialog is created? It's rather annoying to have to switch from AngelScript to C/C++ every time, when that's all I program in lately.

Yes, but I just stopped commiting changes. It will have to wait till after the move is complete.

[Urxae]

By the way, is there any way it can remember which language I had last selected and open that one when the dialog is created? It's rather annoying to have to switch from AngelScript to C/C++ every time, when that's all I program in lately.

Yes, but I just stopped commiting changes. It will have to wait till after the move is complete.

Submitted a feature request as a reminder: [ 1366192 ]

[takeshimiya]

Urxae: I was just about to submit the request for that feature :shock:

I had it written even various days ago:

Actual behaviour:
    In the Settings->Editor->Color, the last "Color Theme" used gets saved but the
    "Syntax highlighting for" no. And gets a little annoying when you are testing how the colors
    look in "C/C++" for example, and nVidia cg gets selected.
Expected behaviour:
    Just save as a configuration the "Syntax highlighting for", and perhaps the last type selected
    also (a comment, number, etc)

[Urxae]

Urxae: I was just about to submit the request for that feature :shock:

Great minds...

I had it written even various days ago:

Actual behaviour:
    In the Settings->Editor->Color, the last "Color Theme" used gets saved but the
    "Syntax highlighting for" no. And gets a little annoying when you are testing how the colors
    look in "C/C++" for example, and nVidia cg gets selected.
Expected behaviour:
    Just save as a configuration the "Syntax highlighting for", and perhaps the last type selected
    also (a comment, number, etc)

Ah, so it was you that anonymously added that text as a comment?
Though I always get Angelscript as the default selection.

[takeshimiya]

Hehe, as I said, I had written the text like 2 weeks ago, when the AngelScript support wasn't there, and nVidia CG was first

In fact, I have a big list of text of my feature requests/bugs waiting in my HD