News:

When registered with our forums, feel free to send a "here I am" post here to differ human beings from SPAM bots.

Main Menu

Bug Report

Started by Landslyde, March 09, 2018, 10:07:11 PM

Previous topic - Next topic
Print
Go Down Pages1
User actions

Landslyde

March 09, 2018, 10:07:11 PM
Here's the codeblocks.xml and my report of how the crash happened.

oBFusCATed

#1
March 09, 2018, 10:46:21 PM
Generally it is best to post the notes either in the ticket section on sf.net or as a message in the forum.
I can reproduce it...
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Landslyde

#2
March 09, 2018, 11:18:22 PM
sf.net. Will do that next time.

Thanks.

oBFusCATed

#3
March 10, 2018, 12:19:04 AM
This patch should fix the problem. No idea why it happens, but I don't have more time to spend on this plugin.

The plugin isn't in really good shape.
I was able to trigger several wx assert just clicking randomly.
So it would be good if someone volunteers to clean them up.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Miguel Gimenez

#4
March 21, 2018, 02:21:56 PM
I have patched two asserts (clicking Settings and clicking About) and cleaned a bit the code (see ticket 644). The attached file contains all the patches posted in that ticket.

Pecan

#5
March 21, 2018, 08:02:51 PM
Quote from: Miguel Gimenez on March 21, 2018, 02:21:56 PM
I have patched two asserts (clicking Settings and clicking About) and cleaned a bit the code (see ticket 644). The attached file contains all the patches posted in that ticket.

Thanks, I'll have a look at it.

Pecan

#6
March 21, 2018, 08:52:31 PM
Quote from: Miguel Gimenez on March 21, 2018, 02:21:56 PM
I have patched two asserts (clicking Settings and clicking About) and cleaned a bit the code (see ticket 644). The attached file contains all the patches posted in that ticket.

How did you create this patch. Tortoise SVN refuses to apply it.
What did you use to apply this patch?

oBFusCATed

#7
March 21, 2018, 09:43:07 PM
He is using git. You have to use patch -p1 < patch.file to apply it.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

oBFusCATed

#8
March 22, 2018, 12:33:31 AM
@Pecan: Have you seen my patch for the message box? Do you think I can apply it without loosing functionality?
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Miguel Gimenez

#9
March 23, 2018, 12:07:36 PM
I created it with SVN but using the --git option, I will remove it next time.

Thank you for the fix, ticket 644 can be closed.

Pecan

#10
March 23, 2018, 08:27:21 PM
Quote from: oBFusCATed on March 22, 2018, 12:33:31 AM
@Pecan: Have you seen my patch for the message box? Do you think I can apply it without loosing functionality?

I fixed the dialogs, but maybe I missed something.
Could you remind me of the ticket you refering to?

oBFusCATed

#11
March 23, 2018, 09:04:13 PM
I don't know about the tickets. The discussion about this happened mainly here.

So should I remove the GenericMessageDialog or it add something that is not available with the wxMessageDialog?
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Pecan

#12
March 24, 2018, 04:17:05 PM
Quote from: oBFusCATed on March 23, 2018, 09:04:13 PM
I don't know about the tickets. The discussion about this happened mainly here.

So should I remove the GenericMessageDialog or it add something that is not available with the wxMessageDialog?

Thanks, I'll have a look at it.

Pecan

#13
March 24, 2018, 10:31:30 PM
Applied GenericMessageBox patch and cleaned out unused code and dirs
SVN 11346
Print
Go Up Pages1
User actions