News:

Accounts with zero posts and zero activity during the last months will be deleted periodically to fight SPAM!

Main Menu

small clean up in cbeditor

Started by frithjofh, May 27, 2018, 06:07:37 PM

Previous topic - Next topic

frithjofh

hi everyone,

i am proposing a small code change in the area of cbeditor.

i removed a variable in editorbase which was used to hold the information whether a given pointer refers to a builtin editor or not. i replaced it with the proper override in the derived class.

reasoning: 1) breaks nothing 2) expresses more clearly the relationship 3) removes several lines of code

patch file attached.

regards
architect with some spare time  -  c::b compiled from last svn  -   openSuSE leap x86_64  -  AMD FX-4100

oBFusCATed

1 is clearly not true, because you've broken the ABI, so you need to rise the sdk version numbers in the cbplugin.h (just the last number).
Also virtual functions are a bit slower than normal methods. I doubt it would matter too much, but still.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

killerbot