News:

When registered with our forums, feel free to send a "here I am" post here to differ human beings from SPAM bots.

Main Menu

RFC: DefaultWrite mode, CallTip, Completion popup fix

Started by Pecan, July 23, 2023, 08:25:07 PM

Previous topic - Next topic
Print
Go Down Pages 1 2 All
User actions

Pecan

#15
July 30, 2023, 03:04:03 AM Last Edit: July 30, 2023, 03:48:55 AM by Pecan
Can anyone tell me if I need to change the sdk version when I apply this patch?

The patch adds a function declaration in platform.h and an implementation  in platWX.cpp.

ollydbg

#16
July 30, 2023, 09:53:30 AM
Quote from: Pecan on July 30, 2023, 03:04:03 AM
Can anyone tell me if I need to change the sdk version when I apply this patch?

The patch adds a function declaration in platform.h and an implementation  in platWX.cpp.

From my point of view, you code change is inside the scintilla control, I think the interface(wxScintilla) is not changed. So no need to change the sdk version number.
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

Pecan

#17
August 02, 2023, 06:57:03 PM
Patch applied Head r13322.
Print
Go Up Pages 1 2 All
User actions