Move Occurrence highlighting from core into a plugin

[Jenna]

There is one issue with permanently highlighting.

The highlighting will occurr (most of the times) first after clicking into the file (if it is already opened and not the active one).
It's the same when permanently highlighting is turned off for a word: in actual file highlighting is removed immediately, in open files it is removed after clicking into the file at any place.

I can look into it tomorrow, if you want.

This patch fixes it for me on linux.
I did not (yet) test the whole stuff on windows, so it might be a (wx)scintilla on linux/gtk issue only.

Code Select Expand

Index: src/plugins/occurrenceshighlighting/highlighter.cpp
===================================================================
--- src/plugins/occurrenceshighlighting/highlighter.cpp
+++ src/plugins/occurrenceshighlighting/highlighter.cpp
@@ -33,7 +33,8 @@
     if ( Manager::Get()->GetEditorManager()->GetActiveEditor() != ctrl  ) return;

     // check the event type if it is an update event
-    if ( event.GetEventType() == wxEVT_SCI_UPDATEUI )
+    if ( event.GetEventType() == wxEVT_SCI_UPDATEUI ||
+         event.GetEventType() == wxEVT_SCI_PAINTED)
     {
         HighlightOccurrencesOfSelection(ctrl);
         OnEditorUpdateUI(ctrl);


[MortenMacFly]

Next updated patch.

This one applies safely for me. I believe it covers 2+3?

[Jenna]

Next updated patch.

This one applies safely for me. I believe it covers 2+3?

Yes, it does.

[Jenna]

Any comments, issues or whatever ?

I personally think it should be committed to trunk, if everything works as expected.

[MortenMacFly]

Any comments, issues or whatever ?

Go ahead - works fine for me since day 1 posted here.