News:

When registered with our forums, feel free to send a "here I am" post here to differ human beings from SPAM bots.

Main Menu

The 01 September 2015 build (10474) is out.

Started by killerbot, September 01, 2015, 10:14:44 PM

Previous topic - Next topic

ollydbg

Quote from: ollydbg on September 05, 2015, 04:47:50 AM
The second issue is that it looks like the "*" is lost in the Token.
...
Tested again, I see that "*" is only exists in "m_FullType", not in "m_BaseType", then with the following patch, you issue can be solved.

src/plugins/codecompletion/codecompletion.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/plugins/codecompletion/codecompletion.cpp b/src/plugins/codecompletion/codecompletion.cpp
index 4814840..8434566 100644
--- a/src/plugins/codecompletion/codecompletion.cpp
+++ b/src/plugins/codecompletion/codecompletion.cpp
@@ -2742,7 +2742,8 @@ int CodeCompletion::DoAllMethodsImpl()
                 str << ed->GetLineIndentString(line - 1);
             if (addDoxgenComment)
                 str << _T("/** @brief ") << token->m_Name << _T("\n  *\n  * @todo: document this function\n  */\n");
-            wxString type = token->m_BaseType;
+            wxString type = token->m_FullType;
+            // "int *" or "int &" ->  "int*" or "int&"
             if ((type.Last() == _T('&') || type.Last() == _T('*')) && type[type.Len() - 2] == _T(' '))
             {
                 type[type.Len() - 2] = type.Last();

I change the base type to full type.
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

Xaviou

Quote from: ollydbg on September 05, 2015, 04:47:50 AM
@Xaviou
The first issue is fixed in trunk now.
Thank you for your reactivity.

Quote from: ollydbg on September 05, 2015, 04:47:50 AM
The second issue is that it looks like the "*" is lost in the Token.
I don't know if it can help, but I've just saw that the dialog box witch allows to check/uncheck the missing methods we want to add has the correct definition.
Only the inserted code is wrong.

Regards
Xav'
My wxWidgets's stuff : [url="https://wxstuff.xaviou.fr/"]https://wxstuff.xaviou.fr/[/url]

ollydbg

If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.