News:

Accounts with zero posts and zero activity during the last months will be deleted periodically to fight SPAM!

Main Menu

The 16 Januari 2022 build (12655) is out.

Started by killerbot, January 16, 2022, 10:57:36 AM

Previous topic - Next topic

killerbot

We switched to wx 3.1.5 --> download the new wx dll's see link below

Get quick announcements through the RSS feed http://www.codeblocks.org/nightly/CodeBlock_RSS.xml

Before you use a nightly make sure you understand how it works.

A link to the unicode windows wxWidget dll(s) for Code::Blocks : https://sourceforge.net/projects/codeblocks/files/Binaries/Nightlies/Prerequisites/wxmsw31u_gcc_cb_wx315_2D_gcc810-mingw64.7z
A link to Mingw64 dll's needed by Code::Blocks : http://sourceforge.net/projects/codeblocks/files/Binaries/Nightlies/Prerequisites/Mingw64dlls8.1.0.7z


The 16 Januari 2022 build is out.
  - Windows :
   http://sourceforge.net/projects/codeblocks/files/Binaries/Nightlies/2022/CB_20220116_rev12655_win64.7z
  - Linux :
   none

The current SDK version is : 2.16.0

Resolved Fixed:


  • Sort compiler list in compiler detection dialog.
  • Compiler: Use the same shell for cleaning and compiling makefiles (ticket #389
  • wxSmith: Fix compilation when wxUSE_STL=1 (ticket #873)
  • Allow removal from project of multiple selected files (ticket #116)
  • Add Jens Lody's DisplayEvent core plugin. (WIP)

Regressions/Confirmed/Annoying/Common bugs:




AndrewCot

Jens Lody's DisplayEvent core plugin is as expected not in the 7z file as it it not built by default in SVN 12655.

Xaviou

Hi

OS X version of this rev (12596) can be downloaded from my Google Drive.
There is a specific dmg file for versions 10.15 and 11.6 of the OS.
Note that these are not notarized versions of the application.

32 bits version for Windows can also be found in the same place.

Debian Buster and Bullseye (32 and 64 bits) can be installed from my repo.

The problem I talked about in my 9 january's post is still here.
I comes from the rev12597 modifications (this has been confirmed by the fact that disabling the "Forein Project Importer" plugin allows Code::Blocks to run correctly.
The problem is the last loop of the modified code :
wxMenuItemList m_List = m_Menu->GetMenuItems();
    for (wxMenuItemList::iterator it = m_List.begin(); it != m_List.end(); ++it)
        importSubMenu->Append(*it);

The "GetMenuItems" call doesn't detach the menu entries of m_Menu so adding them "as is" to the newly created sub menu is not a good thing (but perhaps am I missing something...)
However, doing something like the following works fine:
wxMenuItemList m_List = m_Menu->GetMenuItems();
wxMenuItem *item;
    for (wxMenuItemList::iterator it = m_List.begin(); it != m_List.end(); ++it)
    {
        item = *it;
        importSubMenu->Append(item->GetId(), item->GetItemLabel);
    }

But in this case, the content of m_Menu seems to never been destroyed.

Regards
Xav'
My wxWidgets's stuff : [url="https://wxstuff.xaviou.fr/"]https://wxstuff.xaviou.fr/[/url]

Miguel Gimenez


Xaviou

Hi
Quote from: Miguel Gimenez on January 20, 2022, 09:33:29 PM
I will check, thank you.
Thank you.

As a complement : the official wxWidgets doc related to wxMenu::Append(wxMenuItem *menuItem) confirm that the item added using this method will be owned by the menu to witch they are added.

Regards
Xav'
My wxWidgets's stuff : [url="https://wxstuff.xaviou.fr/"]https://wxstuff.xaviou.fr/[/url]

Miguel Gimenez

Can you check if this works?

    for (wxMenuItemList::iterator it = m_List.begin(); it != m_List.end(); ++it)
        importSubMenu->Append(m_Menu->Remove(*it));

TIA

Xaviou

Hi
Quote from: Miguel Gimenez on January 20, 2022, 11:29:30 PM
Can you check if this works?

    for (wxMenuItemList::iterator it = m_List.begin(); it != m_List.end(); ++it)
        importSubMenu->Append(m_Menu->Remove(*it));

TIA
It does : Nice.
Don't forget to destroy the menu itself (m_Menu) because it is never done.

Thank you.

Regards
Xav'
My wxWidgets's stuff : [url="https://wxstuff.xaviou.fr/"]https://wxstuff.xaviou.fr/[/url]

Miguel Gimenez

I attached only the relevant part of the patch, the complete version changes m_Menu from private member to local variable and deletes it when not needed.

Thank you for testing.

BTW, there was an issue with some wxChoice not showing on toolbars on MAC (the target selection choice, for example). I made a commit fixing this on Ubuntu, can you check if it fixes the problem on MAC?

AndrewCot

@Miguel The SVN https://sourceforge.net/p/codeblocks/code/12666/ changes do not "delete menu;" on any of the returns between the menu create and the delete you added. More changes are required.

@ALL
I suggest creating tickets and getting the patches reviewed before being applied so the changes can be tracked and reviews done to stop code going onto the trunk that has at least been code reviewed (or had a chance of being reviewed in that if it does not get reviewed with X days then it probably should be deemed to be okay. X IMHO X should be a between 2 and 4 inclusive, but varies around Chrissy and Easter as these are usually holiday periods in large parts of the world with the other holiday periods dependent on the country).

Xaviou

Hi

Quote from: Miguel Gimenez on January 21, 2022, 10:12:48 AM
I attached only the relevant part of the patch, the complete version changes m_Menu from private member to local variable and deletes it when not needed.

Thank you for testing.

BTW, there was an issue with some wxChoice not showing on toolbars on MAC (the target selection choice, for example). I made a commit fixing this on Ubuntu, can you check if it fixes the problem on MAC?

Can't build the last revision : rev 12660 broke the build process.
I've attached the output (and errors) to this post.

Regards
Xav'
My wxWidgets's stuff : [url="https://wxstuff.xaviou.fr/"]https://wxstuff.xaviou.fr/[/url]

Miguel Gimenez

@andrewcot, thank you for pointing this out. This is one of the reasons I dislike multiple return points.

BlueHazzard

Quote from: Xaviou on January 21, 2022, 12:41:03 PM
Hi

Quote from: Miguel Gimenez on January 21, 2022, 10:12:48 AM
I attached only the relevant part of the patch, the complete version changes m_Menu from private member to local variable and deletes it when not needed.

Thank you for testing.

BTW, there was an issue with some wxChoice not showing on toolbars on MAC (the target selection choice, for example). I made a commit fixing this on Ubuntu, can you check if it fixes the problem on MAC?

Can't build the last revision : rev 12660 broke the build process.
I've attached the output (and errors) to this post.

Regards
Xav'
O s**t... i will look into it...
Is this on OSX?

Can you test drag and drop for me if the build works? I have no mac to test this, and i have the worry that DnD does not work on wxCocca

BlueHazzard

@Xaviou
Can you add

#include <wx/dataobj.h>


to src/projectmanagerui.h:12 ?

That should clear most error messages?
I compiled this on linux and windows and did not get any error message...

Xaviou

Quote from: BlueHazzard on January 21, 2022, 02:28:50 PM
@Xaviou
Can you add

#include <wx/dataobj.h>


to src/projectmanagerui.h:12 ?

That should clear most error messages?
I compiled this on linux and windows and did not get any error message...
Tested : it is not enough.
Errors have decreased from 18 to 11 but build is still broken.
I've attached the last build log

Regards
Xav'
My wxWidgets's stuff : [url="https://wxstuff.xaviou.fr/"]https://wxstuff.xaviou.fr/[/url]

BlueHazzard

Thank you for testing...

#include <wx/dataobj.h>
#include <wx/dnd.h>
#include <wx/dataobj.h>


what about this in src/projectmanagerui.h:12 ?

i looked into it and it seems that building for macos without buying an mac is impossible...
what a shame waled garden...