New code completion remarks/issues

[Jenna]

This one does not work for me either in r5790.

[MortenMacFly]

This one does not work for me either in r5790.

...which one?

[Jenna]

This one does not work for me either in r5790.

...which one?

Lieven's sample-code.

[MortenMacFly]

....adding this report:
http://forums.next.codeblocks.org/index.php/topic,11107.msg76268.html#msg76268

[blueshake]

in the latest cc,
in the function void CodeCompletion::EditorEventHook(cbEditor* editor, wxScintillaEvent& event)
inside the function body,
cbStyledTextCtrl* control = editor->GetControl();

there is variable named control,
but when I type cont, the cc don't work.(no control in suggestion list and control's member list didn't work too)
I am sure it work before,at least at ver 5713.

[blueshake]

the same to variable event

[blueshake]

hello,did anyboby notice that codecompletion bar that miss some function in codecompletion.cpp.
see my snap3 .I can confirm that it work at rev 5731 see  the snap4 .
it seems that the codecompletion's member function were not included in this situation.what is going on ?

[attachment deleted by admin]

[MortenMacFly]

I can confirm that it work at rev 5731 see  the snap4 .

I noticed the same (I told you and Jens...), but this info (the revision) is not really helpful as it is before the merge.

I wonder if it was working in your own test branch before the merge. Because that would be easier to compare.

[blueshake]

yes,I remember it worked in my local copy(I just modify the codecompletion.cpp file),but unluckly,my old  machine is down ,I lost everything.

[blueshake]

hello,Morten

good news:
the issue killerbot report can be solved by this patch.
bad news:
can not make a clear explaination here.

Code Select Expand

Index: src/plugins/codecompletion/parser/parserthread.cpp
===================================================================
--- src/plugins/codecompletion/parser/parserthread.cpp (revision 5816)
+++ src/plugins/codecompletion/parser/parserthread.cpp (working copy)
@@ -1051,7 +1051,11 @@
    if (ns == ParserConsts::opbrace)
    {
        // parse inside anonymous namespace
+        Token* lastParent = m_pLastParent;
+        TokenScope lastScope = m_LastScope;
        DoParse();
+        m_pLastParent = lastParent;
+        m_LastScope = lastScope;
    }
    else
    {


[ollydbg]

hello,did anyboby notice that codecompletion bar that miss some function in codecompletion.cpp.
see my snap3 .I can confirm that it work at rev 5731 see  the snap4 .
it seems that the codecompletion's member function were not included in this situation.what is going on ?

Hi, I can confirm this bug in my local copy(based on rev 5816).
Investigating now!

[ollydbg]

I think I have locate the bug. See the image below.



It seems the function before the current scope was shown.

So, the parser may fails parsing this function, especially "//" or "\\".

Code Select Expand


wxArrayString GetIncludeDirs(cbProject &project)
{
    wxArrayString dirs;
    {
        wxArrayString target_dirs = project.GetIncludeDirs();

        for(size_t ii = 0; ii < target_dirs.GetCount(); ++ii)
        {
            wxFileName filename;
            NormalizePath(filename, target_dirs[ii]);

            wxString fullname = filename.GetFullPath();
            fullname.Replace(_T("\\"), _T("/"), true);
            if(dirs.Index(fullname) == wxNOT_FOUND)
                dirs.Add(fullname);
        }
    }

    wxString target_name = project.GetActiveBuildTarget();
    ProjectBuildTarget *target = project.GetBuildTarget(target_name);
    if(target)
    {
        wxArrayString target_dirs = target->GetIncludeDirs();
        for(size_t ii = 0; ii < target_dirs.GetCount(); ++ii)
        {
            wxFileName filename;
            NormalizePath(filename, target_dirs[ii]);

            wxString fullname = filename.GetFullPath();
            fullname.Replace(_T("\\"), _T("/"), true);
            if(dirs.Index(fullname) == wxNOT_FOUND)
                dirs.Add(fullname);
        }
    }
    return dirs;
}



[blueshake]

@ollydbg


can you provide the patch?
I believe there is some connection among reply #19,20,21.if this issue can be solved,
others wil too.

[killerbot]

hello,Morten

goog news:
the issue killerbot report can be solved by this patch.
bad news:
can not make a clear explaination here.

Code Select Expand

Index: src/plugins/codecompletion/parser/parserthread.cpp
===================================================================
--- src/plugins/codecompletion/parser/parserthread.cpp (revision 5816)
+++ src/plugins/codecompletion/parser/parserthread.cpp (working copy)
@@ -1051,7 +1051,11 @@
    if (ns == ParserConsts::opbrace)
    {
        // parse inside anonymous namespace
+        Token* lastParent = m_pLastParent;
+        TokenScope lastScope = m_LastScope;
        DoParse();
+        m_pLastParent = lastParent;
+        m_LastScope = lastScope;
    }
    else
    {


YES, I can confirm this works now !!!

[ollydbg]

@ollydbg


can you provide the patch?
I believe there is some connection among reply #19,20,21.if this issue can be solved,
others wil too.

I can't figure out yet till now