wxIsalpha issue in tokenizer

[ollydbg]

Code Select Expand


    wxChar a = _T('中');
    if(wxIsalpha(a))
    {
        ....
    }

The if clause will run. We have such code:

Code Select Expand


wxString Tokenizer::DoGetToken()
{
    int start = m_TokenIndex;
    bool needReplace = false;

    wxString str;
    wxChar   c = CurrentChar();

    if (c == '_' || wxIsalpha(c))
    {
        // keywords, identifiers, etc.

        // operator== is cheaper than wxIsalnum, also MoveToNextChar already includes IsEOF
        while (    ( (c == '_') || (wxIsalnum(c)) )
               &&  MoveToNextChar() )
            c = CurrentChar(); // repeat

        if (IsEOF())
            return wxEmptyString;

        needReplace = true;
        str = m_Buffer.Mid(start, m_TokenIndex - start);
    }


I'm not sure the Chinese character entered in code will cause some problem.

Like: Re: ² character bug

[MortenMacFly]

I'm not sure the Chinese character entered in code will cause some problem.

Well I believe we had that just recently - IMHO the compiler will compile code that uses non-ASCII characters for variable / function names. No the assumption is correct. Its not nice and actually ugly and evil - but its not an error.