variable/type name question

[ollydbg]

Code Select Expand


   // pair of current-file-filter
   TokenFilesSet    m_CurrentFileSet;
   TokenIdxSet      m_CurrentTokenSet;
   TokenIdxSet      m_CurrentGlobalTokensSet;


and:

Code Select Expand


for (TokenFilesSet::const_iterator itf = m_CurrentFileSet.begin(); itf != m_CurrentFileSet.end(); ++itf)


See, we have XXXXsSet or XXXXSet?
I think we should choose one kind of name theme for all the source files.

EDIT:
Just query on Google, like:

"fileVector" filetype:cpp   -> 1440 results
"filesVector" filetype:cpp -> 75 results

"threadpool" filetype:cpp -> 23600 results
"threadspool" filetype:cpp  -> 10 results

Compare the other similar result, we should use XXXXSet, right?

[MortenMacFly]

Compare the other similar result, we should use XXXXSet, right?

Yes.

[ollydbg]

Compare the other similar result, we should use XXXXSet, right?

Yes.

OK, so we need to re-factor on those names, also it looks like "tokenstree.h/cpp" should be "tokentree.h/cpp".

[MortenMacFly]

OK, so we need to re-factor on those names, also it looks like "tokenstree.h/cpp" should be "tokentree.h/cpp".

Oh dear... some more effort... but yes.

[ollydbg]

OK, so we need to re-factor on those names, also it looks like "tokenstree.h/cpp" should be "tokentree.h/cpp".

Oh dear... some more effort... but yes.

I did a lot of names change in rev 8364, please help to change the file names. That may change the makefiles also which I don't familiar. Thanks.

[MortenMacFly]

I did a lot of names change in rev 8364, please help to change the file names.

...should be done in SVN trunk.

[ollydbg]

I did a lot of names change in rev 8364, please help to change the file names.

...should be done in SVN trunk.

Thanks.