Squirrel script with error : UnixFilename()

[LETARTARE]

hello,
with r8466:
the execution of this script causes an error on the "UnixFilename ()":

Code Select Expand


///-----------------------------------------------------------------------------
/// test_UnixFilename.script : LETARTARE 15-10-2012
///-----------------------------------------------------------------------------

function SetBuildOptions (base) {
}
///-----------------------------------------------------------------------------
function main() {
/// path file configuration
local Nameconf = _T("default.conf");
/// locate 'default.conf'
local pathconf = ::LocateDataFile(Nameconf, ::sdAllKnown);
/// results
::print (pathconf)
/// ===> Squirrel error from revision r8394  <===
::print (UnixFilename(pathconf))
}
///-----------------------------------------------------------------------------
///  Vista business Pack2 , Mingw32 with TDM-GCC 4.5.2,  wxWidgets unicode 2.8.12
///  C::B ...r8393, r8394...r8466
///-----------------------------------------------------------------------------

///-----------------------------------------------------------------------------
///  with <= r8393  : it's good

/// C:\Users\aaa\AppData\Roaming\CodeBlocks\default.conf
/// C:\Users\aaa\AppData\Roaming\CodeBlocks\default.conf
///-----------------------------------------------------------------------------
///  with >= r8394  : Squirrel error

///  Message :
///  AN ERROR HAS OCCURED [Incorrect function argument]
///  CALLSTACK
///  *FUNCTION [main()] test_UnixFilename.script line [17]
///  *FUNCTION [main()] ScriptConsole line [1]
///-----------------------------------------------------------------------------
looking, I found that the error occurs since r8394.

I think MortenMacFly realized the r8394.

Can you help me?
cordially

[Jenna]

looking, I found that the error occurs since r8394.

Are you sure it occurs with r8394 ?
I don't see anything related to scripting in this revision.

[LETARTARE]

yes
I tried with r8393 and I have no error.
In changing MortenMacFly, I did not find any relationship with UnixFilename ()!

[MortenMacFly]

...try to replace:
::print (UnixFilename(pathconf))

...with:
::print (UnixFilename(pathconf,wxPATH_NATIVE))

Does it work now?

[LETARTARE]

hello,
thank you.
I tried with r8394, r8466 and I have no error.

-> Include\global.h is written:
r8393 :

Code Select Expand

extern DLLIMPORT wxString UnixFilename(const wxString& filename);
r8394 ... r8466:

Code Select Expand


extern DLLIMPORT wxString UnixFilename(const wxString& filename, wxPathFormat format = wxPATH_NATIVE);

of course must specify the defaults in Squirrel !!

But why the change from r8394 ?

Thank you again.

[Jenna]

8394 has no such change

I did not look into later revisions.
No time at vthe moment,sorry.

[MortenMacFly]

But why the change from r8394 ?

Inspect the SVN log for a description.

BTW: Is it working with the proposed change or not?

[LETARTARE]

YES it works very well as shown MortenMacFly.

[Alpha]

Maybe overload instead of default arguments then?  ... except this does not compile because squirrel cannot figure out what to bind.

Code Select Expand


Index: src/include/globals.h
===================================================================
--- src/include/globals.h (revision 8478)
+++ src/include/globals.h (working copy)
@@ -186,7 +186,8 @@
extern DLLIMPORT wxString MakeUniqueString(const wxString& text,  const wxString& separator = DEFAULT_ARRAY_SEP, bool caseSens = true);
extern DLLIMPORT void AppendArray(const wxArrayString& from, wxArrayString& to);

-extern DLLIMPORT wxString UnixFilename(const wxString& filename, wxPathFormat format = wxPATH_NATIVE);
+extern DLLIMPORT wxString UnixFilename(const wxString& filename/*, wxPathFormat format = wxPATH_NATIVE*/);
+extern DLLIMPORT wxString UnixFilename(const wxString& filename, wxPathFormat format/* = wxPATH_NATIVE*/);
extern DLLIMPORT void QuoteStringIfNeeded(wxString& str);

/// Escapes spaces and tabs (NOT quoting the string)
Index: src/sdk/globals.cpp
===================================================================
--- src/sdk/globals.cpp (revision 8478)
+++ src/sdk/globals.cpp (working copy)
@@ -211,6 +211,11 @@
         to.Add(from[i]);
}

+wxString UnixFilename(const wxString& filename)
+{
+    return UnixFilename(filename, wxPATH_NATIVE);
+}
+
wxString UnixFilename(const wxString& filename, wxPathFormat format)
{
     wxString result = filename;


[MortenMacFly]

Maybe overload instead of default arguments then?

I don't think this is needed. Squirrel does not handle default parameters by design, so as a general rule you always have to provide all parameters for all interfaces. This applies to all squirrel bindings. As we cannot change every method with a default parameter to an overloaded one, developers just have to follow this simple rule:
If there is a default parameter, specify it. Period.

It has been like that since the beginning btw, just as we changed the interface of that methods now you'll need to provide an additional parameter when using it. But this won't hurt.