Building from the new SF repo

[Commaster]

Should be fixed in svn r8926.

svn build rev 8926 (2013-03-29 21:04:23) gcc 4.7.2 Linux/unicode - 64 bit
Thank you very much!
We can now lock this topic, I think...

[Folco]

Thanks for this quick fix ! And don't be sorry Jens, the work of the CB team is just awesome

[stefanos_]

Latest revision compiles fine under Debian wheezy, 32-bit but the crashing issue with cleaning "Recent Projects > Clear History" still exists. I ran it via terminal and reports a Segmentation Fault.

Steps taken with gdb:

Code Select Expand

Loading toolbar...
Initializing plugins...
KeyBinder failed UpdateById on[3401][_Export]
KeyBinder failed UpdateById on[1019][Cu_t]
KeyBinder failed UpdateById on[1018][_Copy]
KeyBinder failed UpdateById on[1020][_Paste]

Program received signal SIGSEGV, Segmentation fault.
0x00000018 in ?? ()
(gdb) c
Continuing.

Program received signal SIGSEGV, Segmentation fault.
0xb657be48 in ?? () from /lib/i386-linux-gnu/libgcc_s.so.1
(gdb) c
Continuing.
[Thread 0xae05eb70 (LWP 9414) exited]
[Thread 0xb0321b70 (LWP 9379) exited]
[Thread 0xb0b22b70 (LWP 9378) exited]
[Thread 0xb1323b70 (LWP 9377) exited]
[Thread 0xb5fd5880 (LWP 9157) exited]

Program terminated with signal SIGSEGV, Segmentation fault.
The program no longer exists.
(gdb)

I hope it helps a bit; I don't know how to use it properly, therefore show some respect

Update: This time decided to throw a window with report: http://pastebin.com/bLqUevvm

[oBFusCATed]

I hope it helps a bit; I don't know how to use it properly, therefore show some respect

No, probably next time try to use the bt command, so the place where it have crashed is visible.

But don't worry this time because I get the crash, too.

[Folco]

I confirm that now, it compiles again. Thanks

[stefanos_]

I hope it helps a bit; I don't know how to use it properly, therefore show some respect

No, probably next time try to use the bt command, so the place where it have crashed is visible.

But don't worry this time because I get the crash, too.

I have done so, and I hope it did it properly

Here you are: http://pastebin.com/s2LbzixV

[Jenna]

I hope it helps a bit; I don't know how to use it properly, therefore show some respect

No, probably next time try to use the bt command, so the place where it have crashed is visible.

But don't worry this time because I get the crash, too.

I have done so, and I hope it did it properly

Here you are: http://pastebin.com/s2LbzixV

The crash happens, because the pointers holding the wxFileHistory-object for the projects and the files in MainFrame get recreated, but the pointers stored in the starthere-page are not updated.

Can you please test the attached patch ?

[oBFusCATed]

Can you please test the attached patch ?

Don't bother, I'm currently fixing this in a rather brutal way:)

[Jenna]

Can you please test the attached patch ?

Don't bother, I'm currently fixing this in a rather brutal way:)

The patch already by resetting the two pointers in the startherepage class at the end of MainFrame::InitializeRecentFilesHistory(), that's the only place where the pointers get recreated in MainFrame.
Another (probably better) approach would be to have a (probably protected?) getter-function in MainFrame for the pointers, make both classes friends and always fetch the pointers if needed (not too expensive, because this happens not very often).

[stefanos_]

yep, the patch works just fine. Shall I fetch the latest updates and adjust to those?

[oBFusCATed]

Jens:
A really better approach is what I'm doing -> remove the code duplication by extracting the code for a single list in its own class.
Then I'll see if this logic can be simplified, further.
Please don't commit.

[stefanos_]

@Jens: The issue remains the same with Windows XP SP3, TDM's GCC 4.7.1-2, 32-bit, wxMGW-2.18.12; it crashes upon cleanup.

[oBFusCATed]

Check trunk head for the changes. Report any problems you encounter with the new version.

[stefanos_]

With the latest revision, it compiles on Windows and cleans the project history just fine. I will compile the latest revision on Debian wheezy too and let you know if not today, by tomorrow.

Cheers

[stefanos_]

Under Debian wheezy, the latest revision throws the following errors:

Code Select Expand

startherepage.h: In member function 'void StartHerePage::SetProjectsFiles(const wxFileHistory*, const wxFileHistory*)':
startherepage.h:32:74: error: no match for 'operator=' in '((StartHerePage*)this)->StartHerePage::m_projects = projects'
startherepage.h:32:74: note: candidate is:
recentitemslist.h:10:7: note: RecentItemsList& RecentItemsList::operator=(const RecentItemsList&)
recentitemslist.h:10:7: note:   no known conversion for argument 1 from 'const wxFileHistory*' to 'const RecentItemsList&'
startherepage.h:32:94: error: no match for 'operator=' in '((StartHerePage*)this)->StartHerePage::m_files = files'
startherepage.h:32:94: note: candidate is:
recentitemslist.h:10:7: note: RecentItemsList& RecentItemsList::operator=(const RecentItemsList&)
recentitemslist.h:10:7: note:   no known conversion for argument 1 from 'const wxFileHistory*' to 'const RecentItemsList&'
main.cpp: In member function 'void MainFrame::InitializeRecentFilesHistory()':
main.cpp:2192:48: error: 'm_pProjectsHistory' was not declared in this scope
main.cpp:2192:68: error: 'm_pFilesHistory' was not declared in this scope
make[3]: *** [main.o] Error 1
make[3]: Leaving directory `/home/stefanos/svn_code/CodeBlocks/src/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/stefanos/svn_code/CodeBlocks/src/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/stefanos/svn_code/CodeBlocks/src'
make: *** [all-recursive] Error 1