Move some GUI code from sdk to src

[MortenMacFly]

In fact if you like it could be made as a single commit (I suppose).

No, please don't. If what you described works I am surely fine with it.

[oBFusCATed]

Anyone willing to test if the branch compiles (and works) on Windows?

[MortenMacFly]

Anyone willing to test if the branch compiles (and works) on Windows?

Compiling requires some more patching (i.-e. the CodeSnippets plugin). I can tell you where once I've got it completed...

Concerning the interface: Is there a reason why GetUI() returns a reference and not a pointer? It looks a bit weird, especially things like this:
Manager::Get()->GetProjectManager()->GetUI().GetTree()->Whatever();

[MortenMacFly]

...turns out it wasn't much in the end - the most places were due to my local changes.

So, attached is a patch to fix the build errors on Windows. Starting C::B and (little) working with it seems to be normal... anything special one should test?

[oBFusCATed]

anything special one should test?

Virtual folders, I never use them

GetUI returns reference to document that the result is always valid
I'll probably move it to the Manager class.

[oBFusCATed]

Code Select Expand


diff --git a/src/batch_build_all.bat b/src/batch_build_all.bat
index 15b600e..e6aad9d 100644
--- a/src/batch_build_all.bat
+++ b/src/batch_build_all.bat
@@ -6,7 +6,7 @@ if not defined CB_ROOT set CB_ROOT=C:\Devel\CodeBlocks
rem ------------------------------------------
rem Setup GCC root folder with "bin" subfolder
rem ------------------------------------------
-if not defined GCC_ROOT set GCC_ROOT=C:\Devel\GCC46TDM
+if not defined GCC_ROOT set GCC_ROOT=%CB_ROOT%\MinGW
rem change this name to suit your needs
rem if not defined CB_RUN_UPDATE_BAT set CB_RUN_UPDATE_BAT=0

This seems like a separate change...

[MortenMacFly]

This seems like a separate change...

Ooops - yes, this was needed so I could batch-compile it on my PC.

I'll play with virtual folders in the evening...

[oBFusCATed]

Do you have some feedback, because I want to merge this code in trunk?

[MortenMacFly]

Do you have some feedback, because I want to merge this code in trunk?

Sorry for the late answer, I've been taking holidays for ~2 weeks. I was unexpectedly off-line due to being nearby the Danish border which caused by mobile internet connection to log into the Danish network all the time. To avoid massive roaming costs I had to switch it off completely.

Well up to now I didn't see any crash, bugs, missing features or alike. It seemed to work with already with the version I used dating ~3 weeks ago. If you did further changes since then I cannot tell...

[oBFusCATed]

I've merged the code already...

Also I've found an issue - clicking in the empty space of the tree doesn't popup the context menu

[MortenMacFly]

I've merged the code already...

Ooops - seems I am in the beginning of catching up...

Also I've found an issue - clicking in the empty space of the tree doesn't popup the context menu

Question is: What happened earlier? Maybe it was always like that?

[oBFusCATed]

No, it is a regression for sure, because I've used this feature a lot and now I'm just clicking in the empty space without result.

[oBFusCATed]

The problems is pretty strange. The EVT_COMMAND_RIGHT_CLICK is there, but it never gets fired
Using Connect doesn't work, too. The same code in the old revision works fine....

[MortenMacFly]

The problems is pretty strange. The EVT_COMMAND_RIGHT_CLICK is there, but it never gets fired
Using Connect doesn't work, too. The same code in the old revision works fine....

In which part of the code are you?

[oBFusCATed]

src/src/projectmanagerui.cpp