memory leak in m_debuggerMenuHandler in SRC target

[ollydbg]

Code Select Expand


void MainFrame::SetupDebuggerUI()
{
    m_debuggerMenuHandler = new DebuggerMenuHandler;
    m_debuggerToolbarHandler = new DebuggerToolbarHandler(m_debuggerMenuHandler);
    m_debuggerMenuHandler->SetEvtHandlerEnabled(false);
    m_debuggerToolbarHandler->SetEvtHandlerEnabled(false);
    wxWindow* window = Manager::Get()->GetAppWindow();
    if (window)
    {
        window->PushEventHandler(m_debuggerMenuHandler);
        window->PushEventHandler(m_debuggerToolbarHandler);
    }
    m_debuggerMenuHandler->SetEvtHandlerEnabled(true);
    m_debuggerToolbarHandler->SetEvtHandlerEnabled(true);
....


Question: I can't find there is a place to "delete m_debuggerMenuHandler", does it mean the wxwidgets framework can delete it? Or there is memory leak?

[oBFusCATed]

Or there is memory leak?

Just a memory leak. wxWidgets deletes only window type of object, I suppose.
I'll take care of it.

[ollydbg]

Fev 8995 fix one memory leak(m_debuggerMenuHandler), what about m_debuggerToolbarHandler?

[oBFusCATed]

Fev 8995 fix one memory leak(m_debuggerMenuHandler), what about m_debuggerToolbarHandler?

Fix it the same way.

[ollydbg]

Fev 8995 fix one memory leak(m_debuggerMenuHandler), what about m_debuggerToolbarHandler?

Fix it the same way.

I fixed it in rev 8998.