News:

The new Release 25.03 is out! You can download binaries for Windows and many major Linux distros here .

Main Menu

Todo list plugin improvements, do not refresh the list after double click

Started by ollydbg, June 03, 2014, 04:45:47 AM

Previous topic - Next topic
Print
Go Down Pages1
User actions

ollydbg

June 03, 2014, 04:45:47 AM
I have a serial of git patches to fix this issue, I will put it here for comments and review for a few days, if no objections, I will commit to the trunk.

The change log:

Quote* todo list plugin: disable refresh the list on double click. When user double click on a todo list item, it will move the caret to the source location, since the source file is already parsed, we don't need to parse it again.

* todo list plugin: use the second kind of constructor of wxCombobox, as it can given a wxArrayString reference, no hard-coded number is needed.

- todo list plugin: add debug logs (it is currently disabled)

- todo list plugin: remove unused member variable ToDoList::m_timer.

- todo list plugin: remove an unused function prototype

- todo list plugin: add many comments (no functional change)

If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

oBFusCATed

#1
June 03, 2014, 09:59:52 AM
Why don't you just make a branch in github?
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

ollydbg

#2
June 03, 2014, 11:28:52 AM
Quote from: oBFusCATed on June 03, 2014, 09:59:52 AM
Why don't you just make a branch in github?
The reason is that github sometimes will be blocked here, so access to it is not quite stable.... :(
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

oBFusCATed

#3
June 03, 2014, 08:12:16 PM
Bleh...
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

ollydbg

#4
June 15, 2014, 01:24:29 PM
The patches are in trunk now. ;D
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.
Print
Go Up Pages1
User actions