News:

When registered with our forums, feel free to send a "here I am" post here to differ human beings from SPAM bots.

Main Menu

The 30 August 2014 build (9884) is out.

Started by killerbot, August 30, 2014, 05:30:14 PM

Previous topic - Next topic

edison

Thanks, it works.

Can you review and submit it ?

Index: options_clang.xml
===================================================================
--- options_clang.xml (revision 9916)
+++ options_clang.xml (working copy)
@@ -185,7 +185,7 @@
         <Command name="LinkNative"
                  value="$linker $libdirs -o $exe_output $link_objects $link_resobjects $link_options $libs -Wl,--subsystem,native"/>
         <Command name="LinkExe"
-                 value="$linker $libdirs -o $exe_output $link_objects $link_resobjects $link_options $libs -mwindows"/>
+                 value="$linker $libdirs -o $exe_output $link_objects $link_resobjects $link_options $libs -Wl,--subsystem,windows"/>
         <Command name="LinkDynamic"
                  value="$linker -shared -Wl,--output-def=$def_output -Wl,--out-implib=$static_output -Wl,--dll $libdirs $link_objects $link_resobjects -o $exe_output $link_options $libs"/>
     </if>

ollydbg

If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

oBFusCATed

@edison: Which version of clang is the last one that supported the old switch?
@alpha: Can we make this parse the version of clang and then pass the appropriate option?
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

stahta01

Quote from: oBFusCATed on October 22, 2014, 10:27:42 PM
@edison: Which version of clang is the last one that supported the old switch?
@alpha: Can we make this parse the version of clang and then pass the appropriate option?

I think going with the first clang version to support the new switch is also an option.

Tim S.
C Programmer working to learn more about C++.
On Windows 10 64 bit and Windows 11 64 bit.
--
When in doubt, read the CB WiKi FAQ. [url="http://wiki.codeblocks.org"]http://wiki.codeblocks.org[/url]

Alpha

Oops, must have missed this.  Yes, I should be able to add a quick regex.  Will do some testing this weekend to see what is necessary.

edison

Quote from: oBFusCATed on October 22, 2014, 10:27:42 PM
@edison: Which version of clang is the last one that supported the old switch?

I don't know...

http://comments.gmane.org/gmane.comp.compilers.clang.devel/38114

Reid Kleckner said:
QuoteI doubt we ever recognized this argument.  This probably changed because we started rejecting unknown -m flags.

oBFusCATed

Quote from: Alpha on October 23, 2014, 06:23:51 AM
Oops, must have missed this.  Yes, I should be able to add a quick regex.  Will do some testing this weekend to see what is necessary.
Just keep in mind that dumpversion doesn't do anything useful - always returns 4.2.1 (at least on linux and osx)
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

Alpha

From my experimentation, it seems neither of these flags are necessary.

        <Command name="LinkExe"
-                 value="$linker $libdirs -o $exe_output $link_objects $link_resobjects $link_options $libs -mwindows"/>
+                 value="$linker $libdirs -o $exe_output $link_objects $link_resobjects $link_options $libs -Wl,--subsystem,windows"/>


I will soon commit the equivalent of (for all versions of clang)

       <Command name="LinkExe"
                value="$linker $libdirs -o $exe_output $link_objects $link_resobjects $link_options $libs"/>

if there are no reported issues with it.

edison

Quote from: Alpha on October 30, 2014, 02:32:45 AM
I will soon commit the equivalent of (for all versions of clang)

       <Command name="LinkExe"
                value="$linker $libdirs -o $exe_output $link_objects $link_resobjects $link_options $libs"/>

if there are no reported issues with it.

This will cause a console window below the gui window, make it not a "GUI application".

Alpha

Quote from: edison on October 30, 2014, 09:40:33 AM
This will cause a console window below the gui window, make it not a "GUI application".
Oh dear... flawed test cases.  I am so embarrassed. :-[
I think I must be spending too much time under linux.

(Thank you.)