A possible bug in 'cbproject.cpp'

[scarphin]

At line 780 of file 'src/sdk/cbproject.cpp':

Code Select Expand

if (existing == pf)
checks if the file is already added to the project. I don't understand this.

'pf' is allocated at line 650 in the same function:

Code Select Expand

pf = new ProjectFile(this);
and 'existing' is a search result:

Code Select Expand

ProjectFile* existing = GetFileByFilename(pf->relativeFilename, true, true);
Why would 'pf' and 'existing' be equal even if they have the same file name? Shouldn't the check expression be like that:

Code Select Expand

if (existing != nullptr)
This actually works but the former doesn't. Am I wrong about this?

[oBFusCATed]

Fixed in svn... Lets see how many projects I've broken.  :