Windows Nighly Recent crash issue for Environment setting.

[scarphin]

Can a C++ expert explain how sel can hold the result of new EnvVariableListClientData(key, value)?

Edit: Or does the sequence operator "," do something different in C++ than I think it does?

I'm not a C++ expert but 'sel' has nothing to with 'new EnvVariableListClientData(key, value)':

Code Select Expand

int  sel     = lstEnvVars->Append(key + _T(" = ") + value, new nsEnvVars::EnvVariableListClientData(key, value));
invokes the overloaded 'Append' function with 2 arguments, there is no sequencing here. Sorry if I misunderstood you and you were talking about something else.

CB crashes at line 479 in 'envvars_common.cpp', I don't think 'Append' is the problematic part.

[stahta01]

Can a C++ expert explain how sel can hold the result of new EnvVariableListClientData(key, value)?

Edit: Or does the sequence operator "," do something different in C++ than I think it does?

I'm not a C++ expert but 'sel' has nothing to with 'new EnvVariableListClientData(key, value)':

Code Select Expand

int  sel     = lstEnvVars->Append(key + _T(" = ") + value, new nsEnvVars::EnvVariableListClientData(key, value));
invokes the overloaded 'Append' function with 2 arguments, there is no sequencing here. Sorry if I misunderstood you and you were talking about something else.

CB crashes at line 479 in 'envvars_common.cpp', I don't think 'Append' is the problematic part.

I disagree please look at the line I changed in the patch. Is it not line 479 or 478?

In C.

A = B, C;

Assigns the value of C to A.

OK, I see what you mean now.

Tim S.

[stahta01]

So, I have decided to stop for this night maybe someone will figure it out.
I just am too tired to think of anything other than wxWidgets is NOT likely something in the code.

Edit: I have decided next time to see if the problem exists under wxWidgets 3.0 because it has better asserts in it.

Tim S.

[oBFusCATed]

I'm calling the Append method that takes two parameters a string and a wxClientData object.
I have no idea why this fails.
To see the real cause of the problem you'll need to rebuild wxwidgets in debug mode.

[oBFusCATed]

Also what is the value of sel when it crashes?

[MortenMacFly]

BTW: I can reproduce the crash. I'd vote to revert the last changes applied in SVN because these render the plugin unusable.

[MortenMacFly]

For me it crashes as soon as I try to open the environment settings.

The crash results in line 167 in EnvVarsConfigDlg::LoadSettings() of envvars_cfgdlr.cpp:
if (nsEnvVars::EnvvarArrayApply(var_array, lstEnvVars))
lstEnvVars seems to be valid... very weird.

So I cannot set any environment (not only envvar) settings... that is no good.

[oBFusCATed]

Can someone extract his/her env settings from default.conf and share them?

[stahta01]

Can someone extract his/her env settings from default.conf and share them?

Code Select Expand


<envvars>
<sets>
<default>
<ENVVAR0>
<str>
<![CDATA[1|LC_ALL|en_US.utf8]]>
</str>
</ENVVAR0>
</default>
<wx28>
<ENVVAR0>
<str>
<![CDATA[1|wxcfg|gcc_dll\mswu]]>
</str>
</ENVVAR0>
<ENVVAR1>
<str>
<![CDATA[1|wxwin|C:\wxMSW\wxMSW-2.8\wxMSW-2.8.12]]>
</str>
</ENVVAR1>
</wx28>
<wx30>
<ENVVAR0>
<str>
<![CDATA[1|wxcfg|gcc_dll\mswu]]>
</str>
</ENVVAR0>
<ENVVAR1>
<str>
<![CDATA[1|wxwin|C:\wxMSW\wxMSW-3.0\wxWidgets-3.0.2]]>
</str>
</ENVVAR1>
</wx30>
</sets>
<ACTIVE_SET>
<str>
<![CDATA[wx30]]>
</str>
</ACTIVE_SET>
<DEBUG_LOG bool="1" />
</envvars>


Tim S.

[stahta01]

Windows CB 10311 edited to enable debug mode with wxWidgets 2.8.12 debug.

Code Select Expand


---------------------------
wxWidgets Debug Alert
---------------------------
../../src/msw/listbox.cpp(441): assert "wxAssertFailure" failed in DoSetItemClientData(): Can't use client data with owner-drawn listboxes
Do you want to stop the program?
You can also choose [Cancel] to suppress further warnings.
---------------------------
Yes   No   Cancel   
---------------------------

---------------------------
wxWidgets Debug Alert
---------------------------
../../src/msw/listbox.cpp(441): assert "wxAssertFailure" failed in DoSetItemClientData(): Can't use client data with owner-drawn listboxes
Do you want to stop the program?
You can also choose [Cancel] to suppress further warnings.
---------------------------
Yes   No   Cancel   
---------------------------


[oBFusCATed]

Rather strange. How on earth does this control get the wxLB_OWNERDRAW style set?
There is no mentioning of wxLB_OWNERDRAW in the whole repo.

And the styles for it in the xrc file are wxLB_SINGLE|wxLB_HSCROLL|wxLB_NEEDED_SB...

[oBFusCATed]

I see this happens because the control is wxCheckListBox... stupid.

[oBFusCATed]

Can someone confirm that this issue is not present in wx30 builds?
Looking at the code I can guess that it should be working fine.

[stahta01]

Can someone confirm that this issue is not present in wx30 builds?
Looking at the code I can guess that it should be working fine.

Will check later today; building wx30 right now.

Tim S.

[stahta01]

Can someone confirm that this issue is not present in wx30 builds?
Looking at the code I can guess that it should be working fine.

Will check later today; building wx30 right now.

Tim S.

It worked with the debug build of wxWidgets 3.0.2.
Going to test the non-debug version next.
Edit: No problem with the non-debug version.

Tim S.