News:

Accounts with zero posts and zero activity during the last months will be deleted periodically to fight SPAM!

Main Menu

Windows XP manifests

Started by sethjackson, January 19, 2006, 10:46:53 PM

Previous topic - Next topic
Print
Go Down Pages1
User actions

sethjackson

January 19, 2006, 10:46:53 PM Last Edit: January 20, 2006, 06:00:43 PM by sethjackson
Hi I was looking at the manifest creation code, and since this is MSW only I added a *gasps* macro :lol: that lets it compile only on MSW (I hope I did it right). Is this OK? I'm going to submit a patch to SF.net if so.....

thomas

#1
January 20, 2006, 09:09:06 AM
Not sure what was intended with that patch, but you put and #ifndef/#error block inside an #ifdef block, so #error inside #ifndef will never be seen.

But hey, no problem, the big #ifdef block is not necessary, I'll just copy the #ifndef block to the header, that'll do just fine and will work the way you intended.
No need to post to SF. :)
"We should forget about small efficiencies, say about 97% of the time: Premature quotation is the root of public humiliation."

sethjackson

#2
January 20, 2006, 05:34:44 PM
Quote from: thomas on January 20, 2006, 09:09:06 AM
Not sure what was intended with that patch, but you put and #ifndef/#error block inside an #ifdef block, so #error inside #ifndef will never be seen.

But hey, no problem, the big #ifdef block is not necessary, I'll just copy the #ifndef block to the header, that'll do just fine and will work the way you intended.
No need to post to SF. :)

Ok I'm not to good with preprocessor macros (I looked at wx sources).....
Print
Go Up Pages1
User actions