Print error

[Jenna]

If yes and there are no objections from other devs, I can commit it.

Looks fine to me.

Jens are you able to print on linux?
My printing broke for some reason and there was another printing problem I'm no long able to look at.

I can print, but scaling is a mess, so the text is nearly unreadable and I have to print all pages to get any output.
If I remember it correctly I tried to work around this years ago and indeed I found a oatch against rev 4905, which is about nine years old.
I will see if it can be used or overworked to enhance/enable printing on Linux.

[oBFusCATed]

I'm trying to print to pdf and the resulting pdf is pretty messed up. Rectangles around every line, text is unreadable because it is overlapping. Cannot switch to portrait mode. I'm not sure all problems are caused by C::B though .
I'm not printing at all so I don't care too much about this feature.

[LETARTARE]

Do I understand it correctly, that the issues are gone with the patch ?

Yes, I print the selected text correctly with the upper and lower panes.

[LETARTARE]

Good evening,
I use again today C::B svn10922 to print.
Printing works correctly on a split window with line numbers, but after printing the line numbers have disappeared!

By searching 'cbEditor::Print (...)', I think I have found the reason
1- missing backup 'getEdgeMode()'
2- need to call 'm_pData->SetLineNumberColWidth(m_pControl && m_pControl2)' to restore the line numbers on the affected windows (1 or 2).

The split working properly after the correction.
Here is the correction since svn10922.

[oBFusCATed]

Patch doesn't apply, please make it against recent trunk

Code Select Expand


$ patch -p1 < /tmp/mozilla_obfuscated0/cbeditorPrint.patch
(Stripping trailing CRs from patch; use --binary to disable.)
patching file sdk/cbeditor.cpp
Hunk #1 FAILED at 2939.
Hunk #2 FAILED at 2990.
2 out of 2 hunks FAILED -- saving rejects to file sdk/cbeditor.cpp.rej


[LETARTARE]

Hello,
here's the fix for svn11019

[oBFusCATed]

In svn, thanks...