Print error

[LETARTARE]

with svn10922, Vista pro pack2.

In a simple pane of the editor, a text selected in a file prints correctly.
With the same split pane, the same text selected, the whole file is printed, not the selection.
Do you have the same behavior ?
Thanks in advance.

[oBFusCATed]

Is this a regression in this revision?

[LETARTARE]

I do not know. That's why I'm asking if this happens with other users.

[oBFusCATed]

Can you try 16.01 or 13.12 or some older night build?

[LETARTARE]

yes :
16.01, svn1816, svn1856 are good

[oBFusCATed]

Do you mean that all versions you've mentioned in the previous post (16.01, 1816 and 1856) are working correctly and only 19022 is broken?

[LETARTARE]

yes,
I only have these versions available :
16.01, svn1816, svn1856 are good
10922 it's broken

[oBFusCATed]

Can you try this one: https://sourceforge.net/projects/codeblocks/files/Binaries/Nightlies/2016/CB_20160621_rev10868_win32.7z/download ?

[LETARTARE]

10868 it's broken.

10816, 10856, 10868 :
The upper pane prints the selected text.
The lower pane prints the entire file !!

10922 :
Two panes (upper and lower) prints the entire file !!

[oBFusCATed]

I'm confused why are you saying that 10868 is broken but list it with the others 10816 and 10856 where I suppose the behaviour is correct? If the first depicted behaviour correct?

Can you test 10912 (or the nightly before 10922) and tell us if it works?

[LETARTARE]

I decided to repeat the tests systematically on the two panels displaying the same file.

These are the only versions I can still use (Vista Business Pack 2,  TDM-GCC 4.7.1, wxWidgets unicode 2.8.12):

16.01, 10118, 10127, 10816, 10856, 10868, 10912, 10922 :
The upper pane prints the selected text.
The lower pane prints the entire file !!

I will try to search in the source, but I do not know where to look?
Do you know which functions handle printing?

[Jenna]

I decided to repeat the tests systematically on the two panels displaying the same file.

These are the only versions I can still use (Vista Business Pack 2,  TDM-GCC 4.7.1, wxWidgets unicode 2.8.12):

16.01, 10118, 10127, 10816, 10856, 10868, 10912, 19022 :
The upper pane prints the selected text.
The lower pane prints the entire file !!

I will try to search in the source, but I do not know where to look?
Do you know which functions handle printing?

One issue is definitely, that the print-function always uses the first control, not the last active one.
Can you test the attached patch ?

[LETARTARE]

Hello,
thanks for patch, good catch.
Of course, the value of pane 1 (m_pControl) was overwritten with the value of pane 2 in cbEditor::Print(bool selectionOnly, PrintColourMode pcm, bool line_numbers) !!

I only tested it on svn10922 : it's good.

Happy New Year.

[Jenna]

Hello,
thanks for patch, good catch.
Of course, the value of pane 1 (m_pControl) was overwritten with the value of pane 2 in cbEditor::Print(bool selectionOnly, PrintColourMode pcm, bool line_numbers) !!

I only tested it on svn19022 : it's good.

Do I understand it correctly, that the issues are gone with the patch ?
If yes and there are no objections from other devs, I can commit it.

Happy New Year.

Many thanks, the same to you !

[oBFusCATed]

If yes and there are no objections from other devs, I can commit it.

Looks fine to me.

Jens are you able to print on linux?
My printing broke for some reason and there was another printing problem I'm no long able to look at.