News:

Accounts with zero posts and zero activity during the last months will be deleted periodically to fight SPAM!

Main Menu

Line duplicated in R11515 (@ollydbg)

Started by Miguel Gimenez, December 11, 2018, 11:45:46 AM

Previous topic - Next topic
Print
Go Down Pages1
User actions

Miguel Gimenez

December 11, 2018, 11:45:46 AM
Commit 11515 duplicated a line in cctest:frame.cpp, giving a redefiition error:

QuotewxString content = m_CompletionTestCtrl->GetValue();

ollydbg

#1
December 11, 2018, 02:52:38 PM
Oh, sorry about this mistake. Definitely a copy and paste error.
I will fix it soon.
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

ollydbg

#2
December 11, 2018, 03:19:12 PM
Fixed in r11516.
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.
Print
Go Up Pages1
User actions