Delete an active target

[LETARTARE]

This test was performed under Vista (win32) and  Cb-11546 compiled with wx28 and Tdm492.
The plugin CC is disabled.

The project attached 'deleteTarget.cbp' (a simple console application) can detect a crash when calls from 'MacrosManager::RecalcVars(...)' and 'MacrosManager::ReplaceMacros(...)',  under the following conditions :
All targets (Release, one, two, three) uses :

• Output filename = bin\$TARGET_NAME)\deleteTarget.exe
• Objects output dir = obj\$TARGET_NAME)\

Targets 'one', 'two', 'three' have more :

• Custom variables : wx = $(#wx28_492)
• Search directories include = $wx\include

- the global variable "#wx28_492" is not used for compilation !, just for demonstration.

All targets compile and work correctly.

• 1- compile and run target 'debug'
• 2- delete active target 'debug'
• 3- it's ok

=> trying to do the same thing with another (active)  target causes a cb crash with a report (attached) !!

A note after removing the 'Debug' target : binary files and '*.o' still exist.

The oldest version without crash seems to be 'cb-11454' nightly build.
No test under Linux.

[BlueHazzard]

And here we probably have it xD  the first bug probably caused by [r11465]

Can you test if [r11464]  works, and if the bug is introduced in [r11465]?

[LETARTARE]

Yes, I will download both versions and try them out...

[LETARTARE]

Indeed 'cb11464' does not crash while 'cb11465' crash (see report).
But what do you mean "it xD" ?

[BlueHazzard]

But what do you mean "it xD" ?

And here we probably have it xD 

This was sarcastic or cynical... It was only a matter of time until someone will find a bug about this patch.

i will look into it...

[BlueHazzard]

The problem is, that the member variable "m_LastTarget" of MacrosManager points to an invalid target after the target is deleted.

The question is how to solve this issue?
1) Reset the MacrosManager if a target is deleted?
2) Only if the "current target == m_LastTarget"?
3) Reset only "m_LastTarget" if the target is deleted?

2) should probably be the solution to go..

[oBFusCATed]

What do you mean by 2? I don't understand.

[BlueHazzard]

What do you mean by 2? I don't understand.

Code Select Expand

if(&deleteTarget==&m_LastTarget)
{
MacrosManager::Reset();
}
This would be a quick fix.

A proper fix would be to use shared_ptr<> and weak_ptr<> on every place a target pointer is used...

[oBFusCATed]

A proper fix would be to use shared_ptr<> and weak_ptr<> on every place a target pointer is used...

I'm not really sure this would be a good idea. For sure it would be quite hard to implement, because you'll probably have to change every file in the repo.

[BlueHazzard]

Code Select Expand

@@ -1310,10 +1310,11 @@ bool cbProject::RemoveBuildTarget(int index)
         // finally remove the target
         delete target;
         m_Targets.RemoveAt(index);
         SetModified(true);
         NotifyPlugins(cbEVT_PROJECT_TARGETS_MODIFIED);
+        Manager::Get()->GetMacrosManager()->Reset();
         return true;
     }
     return false;
}



This fixes this bug...

[oBFusCATed]

OK, commit it...But add a comment why this line is there...

[LETARTARE]

@BlueHazzard
I just checked on cb11546 modified: it does not crash anymore
Thank you.

==> I notice that all deleted targets leave old compilations in their old places.
For the sample provided as an attachment 'deleteTarget.zip'
   

    Output filename = bin\$(TARGET_NAME)\deleteTarget.exe
    Objects output dir = obj\$(TARGET_NAME)\

if  the deleted target is "one" =>
   

    Output filename = bin\one\deleteTarget.exe
    Objects output dir = obj\one\main.o

are kept on the disc !!

==> It should be noted that when we rename a target (active) we also keep on disk old compilations...

[oBFusCATed]

@bluehazzard: Are you gonna commit this fix?

[BlueHazzard]

i currently try to implement a test with squirrel scripting to test some cases with variables and targets, because i feel that this is all a bit fragile, and testing this complex system would not be the worst option...
But it is not that easy to implement them...

[LETARTARE]

I can test your scripts under the versions indicated in my signature.