News:

The new Release 25.03 is out! You can download binaries for Windows and many major Linux distros here .

Main Menu

Toolbar width problem with wxWidgets 3.1.4

Started by gd_on, January 15, 2020, 02:00:08 PM

Previous topic - Next topic
Print
Go Down Pages1
User actions

gd_on

January 15, 2020, 02:00:08 PM
I am trying to test wxWidgets 3.1.4 (updated with git).
I have seen, some time ago, that some toolbars in CodeBlocks are too wide with this version but they were correct with 3.1.3 version.
It appeared very soon after the first releases of version 3.1.4 and hasn't changed since.
May be, there is something to tweak in C::B, but I have not found where it is.
See the effects on the 2 images.

gd_on
Windows 11 64 bits (25H2), svn C::B (last version or almost!), wxWidgets 3.3.2, Msys2 Compilers 16.1.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\msys64\mingw64) or 32 bits (dwarf2, posix  in C:\msys64\mingw32).

oBFusCATed

#1
January 15, 2020, 08:44:35 PM
Does any of View -> Toolbars -> Fit toolbars or optimize toolbars fixes this?
If not bisecting the offending commit in wxwidgets might be helpful.
(most of the time I ignore long posts)
[strangers don't send me private messages, I'll ignore them; post a topic in the forum, but first read the rules!]

gd_on

#2
January 16, 2020, 09:51:44 AM
QuoteDoes any of View -> Toolbars -> Fit toolbars or optimize toolbars fixes this?
No, it does not solve the problem.
QuoteIf not bisecting the offending commit in wxwidgets might be helpful.
The switch between versions 3.1.3 and 3.1.4 took place on 27/10/2019. So, it will not be easy, and surely take a long time to do that...
I tried tp search why some toolbars were correctly sized and some other were not ... but I have not found ...

gd_on
Windows 11 64 bits (25H2), svn C::B (last version or almost!), wxWidgets 3.3.2, Msys2 Compilers 16.1.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\msys64\mingw64) or 32 bits (dwarf2, posix  in C:\msys64\mingw32).

sodev

#3
January 16, 2020, 01:38:52 PM
I am observing the same behavior, it seems that only toolbars which contain a control, in both cases a combobox like one, are affected.

Miguel Gimenez

#4
January 16, 2020, 04:19:19 PM Last Edit: January 16, 2020, 05:11:10 PM by Miguel Gimenez
Your commit is Prevent spurious debug error messages in wxMSW wxToolBar code

https://github.com/wxWidgets/wxWidgets/commit/6878a46725af106758fe166f1334978b89f4a564

EDIT: I have attached the old and new parts of the file. The problem is the toolIndex variable now is incremented only if the tool is not a control. This should be reported to wx devs.

EDIT2: Reported

gd_on

#5
January 16, 2020, 06:27:18 PM
Thanks Miguel.
I was on the good way, but you win  :D
So, we have to wait for a wxWidgets correction probably.
Windows 11 64 bits (25H2), svn C::B (last version or almost!), wxWidgets 3.3.2, Msys2 Compilers 16.1.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\msys64\mingw64) or 32 bits (dwarf2, posix  in C:\msys64\mingw32).

Miguel Gimenez

#6
January 16, 2020, 07:45:43 PM
Sorry, I didn't realize you were already working on this.

gd_on

#8
January 17, 2020, 10:36:46 AM
Thanks again, it's OK now. Thanks also to the author of the patch.
And don't be sorry, you are (one of) the best  ;)

gd_on
Windows 11 64 bits (25H2), svn C::B (last version or almost!), wxWidgets 3.3.2, Msys2 Compilers 16.1.0, 64 bits (seh, posix : gcc, g++ and gfortran in C:\msys64\mingw64) or 32 bits (dwarf2, posix  in C:\msys64\mingw32).
Print
Go Up Pages1
User actions