News:

When registered with our forums, feel free to send a "here I am" post here to differ human beings from SPAM bots.

Main Menu

svn-12539

Started by LETARTARE, December 01, 2021, 04:44:47 PM

Previous topic - Next topic

LETARTARE

svn-12539 :: in plugin contrib 'BrowseTracker_wx30-unix.cbp', the definition of 'cbDEBUG' is missing !!, which causes the non-recognition of 'cbAssertNonFatal()'
CB-13834, plugins-sdk-2.25.0 : Collector-2.6.5, AddOnForQt-5.1.2
1- Win7 Business Pack1 64bits : wx-3.2.8, gcc-15.2.0,
2- OpenSuse::Leap-15.6-64bits : wx-3.2.8;gtk3-u, gcc-15.2.0,
=> !! The messages are translated by 'Deepl'

Pecan

Thanks. Fixed in head r12543

blauzahn

Hello,

I see the same compile error with svn-12556. Here I use ubuntu-20.04 as well as arch linux and
compile cb as usual per command-line, configure and make.

Although the symbol cbDEBUG might be missing in some project(s), IMHO
cbAssertNonFatal should be handled in file src/include/cbexception.h in the same way cbAssert is.

mainly:

#ifndef cbDEBUG
    #define cbAssertMessage(expr)
    #define cbAssertNonFatal(expr)
    #define cbAssert(expr)
#else


Or maybe define them like en.cppreference.com/w/cpp/error/assert.

A patch for the file is attached.

Thanks in advance.


Totoxa

Quote from: Pecan on December 02, 2021, 08:08:32 AM
Thanks. Fixed in head r12543

That fix doesn't work for building from command line (bootstrap, configure, make).

Pecan

Quote from: blauzahn on December 07, 2021, 01:23:54 PM
... IMHO cbAssertNonFatal should be handled in file src/include/cbexception.h in the same way cbAssert is.
mainly:

#ifndef cbDEBUG
    #define cbAssertMessage(expr)
    #define cbAssertNonFatal(expr)
    #define cbAssert(expr)
#else


Thanks, fixed again, Head r12566