News:

When registered with our forums, feel free to send a "here I am" post here to differ human beings from SPAM bots.

Main Menu

Guard needed in r13541

Started by Miguel Gimenez, August 12, 2024, 11:46:09 AM

Previous topic - Next topic

Miguel Gimenez

Revision r13541 added some wx3.2 font styles that are not present in wx3.0, but we still support 3.0 (at least on Linux). These values must be guarded with wxCHECK_VERSION(3, 1, 2) in wxssimplefonteditordlg.cpp:


wxFONTWEIGHT_THIN
wxFONTWEIGHT_EXTRALIGHT
wxFONTWEIGHT_MEDIUM
wxFONTWEIGHT_SEMIBOLD
wxFONTWEIGHT_EXTRABOLD
wxFONTWEIGHT_HEAVY
wxFONTWEIGHT_EXTRAHEAVY
wxFONTWEIGHT_INVALID


ollydbg

If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

Miguel Gimenez


Wkerry

Is there not a CI build that runs for Windows and Linux on any merge like bigger projects do? This would have detected this issue.

Another thing with big dev teams there is peer revies of code changes before they are merged into the trunk. Does this occur with CB? This may have picked it up depending on the reviewers skills.

Miguel Gimenez

Sourceforge does not have these utilities, or at least I do not know about them. Peer reviewing is done sometimes for complex changes.

Miguel Gimenez