News:

Accounts with zero posts and zero activity during the last months will be deleted periodically to fight SPAM!

Main Menu

Small issue in the Start Page

Started by Michael, June 15, 2006, 07:52:57 PM

Previous topic - Next topic

Michael

Hello,

I have remarked both in Window and in Linux (rev 2573 and 256x) that in the Start Page under Recent Projects I have:

Quote

/home/michael/project/ConsoleTest/ConsoleTest.cbp

The point on one line and the path of the project/workspace on another one.

Before, I did not have such "problem".

Best wishes,
Michael
[url="http://img207.imageshack.us/img207/9728/411948picture4em.png"]http://img207.imageshack.us/img207/9728/411948picture4em.png[/url]

mandrav

Because before there was no "bullet point" :)
Now that it's there, the line text is a bit longer and doesn't fit on the same line.
Be patient!
This bug will be fixed soon...

kkez

#2
That's the result of my patch. I wanted something like a list (with dots), but unfortunately using
<ul>
  <li>item</li>
  <li>item</li>
</ul>

produce a bad looking space between adiacent list items, even if there's no <br> between them.
So i tried to manually put a dot ( "&bull;" ) to resemble a list, but i see that neither this works... i can try to break any long path string so you won't get that thing... or remove completely that dot  :)

EDIT: Or we can use <li></li> without a <ul> element, that should work... let me try..

Michael

Quote from: mandrav on June 15, 2006, 07:58:14 PM
Because before there was no "bullet point" :)
Now that it's there, the line text is a bit longer and doesn't fit on the same line.

Hello,

Ok, I understand. Thanks for the reply :). I have thought about a too long text line, but as it worked fine the day before, I have thought of a small bug.

Best wishes,
Michael
[url="http://img207.imageshack.us/img207/9728/411948picture4em.png"]http://img207.imageshack.us/img207/9728/411948picture4em.png[/url]

kkez

Ok, resolved, it was just a matter of a \n that became a <br> for no reason.




Now you see why i wanted a list...

here's my new patch:
Index: src/src/main.cpp
===================================================================
--- src/src/main.cpp (revision 2573)
+++ src/src/main.cpp (working copy)
@@ -1449,27 +1449,31 @@
     links << _T("<b>Recent projects</b><br>\n");
     if (m_ProjectsHistory.GetCount())
     {
+        links << _T("<ul>");
         for (int i = 0; i < 9; ++i)
         {
             if (i >= (int)m_ProjectsHistory.GetCount())
                 break;
-            links << wxString::Format(_T("&bull; <a href=\"CB_CMD_OPEN_HISTORY_PROJECT_%d\">%s</a><br>\n"),
+            links << wxString::Format(_T("<li><a href=\"CB_CMD_OPEN_HISTORY_PROJECT_%d\">%s</a></li>"),
                                         i + 1, m_ProjectsHistory.GetHistoryFile(i).c_str());
         }
+        links << _T("</ul><br>");
     }
     else
         links << _T("&nbsp;&nbsp;&nbsp;&nbsp;No recent projects<br>\n");
-
+   
     links << _T("<br><b>Recent files</b><br>\n");
     if (m_FilesHistory.GetCount())
     {
+        links << _T("<ul>");
         for (int i = 0; i < 9; ++i)
         {
             if (i >= (int)m_FilesHistory.GetCount())
                 break;
-            links << wxString::Format(_T("&bull; <a href=\"CB_CMD_OPEN_HISTORY_FILE_%d\">%s</a><br>\n"),
+            links << wxString::Format(_T("<li><a href=\"CB_CMD_OPEN_HISTORY_FILE_%d\">%s</a></li>"),
                                         i + 1, m_FilesHistory.GetHistoryFile(i).c_str());
         }
+        links << _T("</ul>");
     }
     else
         links << _T("&nbsp;&nbsp;&nbsp;&nbsp;No recent files<br>\n");