News:

Accounts with zero posts and zero activity during the last months will be deleted periodically to fight SPAM!

Main Menu

wrong regular expressions in the bootstrap script

Started by SharkCZ, November 26, 2006, 02:02:58 PM

Previous topic - Next topic

SharkCZ

I have problems when compiling CB on Fedora Development which contains autoconf 2.61. It ends with

+ ./bootstrap
Autoconf 2.50 or above is required. Aborting build...

The reason is a wrong regular expression when checking for the version. The current expression '1.*|2.[0-4]' checks for the following strings
- "1" and zero!!! or more occurences of any character => 2.61 has a match
- "2" and any character and a number between 0 and 4
A point must be checked with '\.' and not with '.'

The secure variant could be '1\.[0-9]+|2\.[0-4]', which will check for version 1.x and 2.0 till 2.4. Similar expression are needed for automake (1\.[0-6]) and libtool (1\.[0-3]) checks.
Code::Blocks package maintainer for Fedora and EPEL

afb


SharkCZ

#2
Automake 1.10 was born one month ago and the current check is wrong and the build is crashing on Fedora Core Development. The expression must be updated again :-)
I cannot find out a positive check that will do >= 1.7, so easier could be a negative one "egrep -v '1\.[7-9]|1\.[1-9][0-9]'". Hopefully is this correct.
Code::Blocks package maintainer for Fedora and EPEL

afb

Fixed, revision 3310. Added a $, to match 1.1 but not 1.10

SharkCZ

So you expect the version string is on the end of line. That is a variant too.
Code::Blocks package maintainer for Fedora and EPEL

afb

Since we cut it out from the --version, it should work OK. (it did for me)

Let me know if it doesn't, or when next bleeding edge FC version arrives :-)

SharkCZ

Code::Blocks package maintainer for Fedora and EPEL

knue

#7
Since I have autoconf 2.61 installed the regular expressions does not work for me neither. I get
Autoconf 2.50 or above is required. Aborting build...
too.

autoconf --version 2>&1|head -n 1|egrep '1.*|2.[0-4]'
gives me:
autoconf (GNU Autoconf) 2.61

Perhaps it should be replaced with:
autoconf --version 2>&1|head -n 1|egrep '1.+|2.[0-4]'
This works for me.

afb



mandrav

Be patient!
This bug will be fixed soon...

knue