Close button for tabs

[rickg22]

I commited the patch for a button to close the tabs. But after considering it, I don't know if this should be good.

Should I move it into the toolbar (next to "open" and "save" icons) ?

Please share your opinions guys.

[attachment deleted by admin]

[Ceniza]

It's nice to see you're already working on it but I consider it's better to put it in the toolbar in the meanwhile.

[darklordsatan]

That is really nice rick. I like it where it is, good job.
BTW, *yuk* are you using win98 or the "classic windows" theme in XP? 

[Ceniza]

I'm still looking at it and I cannot really agree, it looks so lonely.

Maybe, just maybe, if it was a vertical toolbar with more things like: Close, Close all, Close all except this, Find, Find next, Find previous, ...

[rickg22]

the "classic windows" theme

So my question is... doesn't that empty wasted space look ugly?

[darklordsatan]

I dont see it ugly, but its a matter of personal taste, maybe if you could  put it on top of the slidebar (well, probably thats impossible?), but actually its looks perfect, reminds me of firefox.

[zieQ]

Personally, I find it ugly too! As Ceniza said, either you could add a bunch of other buttons, or maybe add this button in right of the dock bar (docked button?)

[Urxae]

I think you should either

• put some more buttons there as mentioned above.
• put it to the right of the tabs, thus making the tab bar shorter than the width of the editor, as Firefox does. (Is this possible?)

Only as a last resort should you put it in the toolbar, IMHO. I don't think it really belongs there.

Anyway, I'm off to update my checkout and compile this new goodie .

[opens Code::Blocks, compiles, realizes this isn't in VERSION_1_0]
Bah :cry:
Any chance this will make it into version 1? This really is a must-have feature, I think. Imagine new users not being able to close a tab efficiently, and that turning them away. Not good.

[Vampyre_Dark]

Why not use middle-click like in firefox to close a tab? Nice and quick.

[tiwag]

Why not use middle-click like in firefox to close a tab? Nice and quick.

i second that suggestion: middle-click is the very best !

[mandrav]

Anyway, I'm off to update my checkout and compile this new goodie .

[opens Code::Blocks, compiles, realizes this isn't in VERSION_1_0]
Bah :cry:
Any chance this will make it into version 1? This really is a must-have feature, I think. Imagine new users not being able to close a tab efficiently, and that turning them away. Not good.

Actually it's only in VERSION_1_0. Keep in mind that anonymous CVS lags a few hours, so you might get the update if you try a little later

Btw, I added a configuration option for this, as I don't really like it, which is disabled by default. To enable it, go to environment settings.

Yiannis.

[Urxae]

Why not use middle-click like in firefox to close a tab? Nice and quick.

Even better! However, I see no reason this can't be combined with any of the others, so why not do this in addition to an actual button?

[zieQ]

I think some folks have already said that middle-click or right-click to tabs are not easy to implement with wxWidgets. Bad news...

[Urxae]

Actually it's only in VERSION_1_0. Keep in mind that anonymous CVS lags a few hours, so you might get the update if you try a little later

Btw, I added a configuration option for this, as I don't really like it, which is disabled by default. To enable it, go to environment settings.

After another CVS update (aside: sourceforge cvs is rather slow at the moment. I hate it when it does that) and 12 minutes of compiling I have sdk\resources\images\closebutton.png but no actual button or configuration option for one. Did that file get checked in earlier than the stuff to actually use it by any chance?

I think some folks have already said that middle-click or right-click to tabs are not easy to implement with wxWidgets. Bad news...

Too bad. Well, let's look at the bright side: at least it's not impossible, right? :wink:

[tiwag]

Actually it's only in VERSION_1_0. Keep in mind that anonymous CVS lags a few hours, so you might get the update if you try a little later

Btw, I added a configuration option for this, as I don't really like it, which is disabled by default. To enable it, go to environment settings.

After another CVS update (aside: sourceforge cvs is rather slow at the moment. I hate it when it does that) and 12 minutes of compiling I have sdk\resources\images\closebutton.png but no actual button or configuration option for one. Did that file get checked in earlier than the stuff to actually use it by any chance?

i've just updated VERSION_1_0 from cvs and the closebutton is there and working,
but no checkbox in environment settings - it looks like that in anonymous cvs
actually is the version which was commited by rickg originally.