News:

When registered with our forums, feel free to send a "here I am" post here to differ human beings from SPAM bots.

Main Menu

The 25 August 2007 build will NOT be out.

Started by killerbot, August 25, 2007, 11:00:38 PM

Previous topic - Next topic

killerbot


thomas

Martin reverted it though? So... nothing to solve?
"We should forget about small efficiencies, say about 97% of the time: Premature quotation is the root of public humiliation."

stahta01

#2
SVN 4410 crashes on my WinXP SP2, wxWidgets 2.8 Branch

Tim S

PS: Trying backgroundthread.h SVN 4181 now to see if it works OK. It seemed to fix the Crash on startup issue. Note, I only changed the one file from SVN 4410.

The patch to revert backgroundthread.h to SVN 4181 is below.

Index: src/include/backgroundthread.h
===================================================================
--- src/include/backgroundthread.h (revision 4410)
+++ src/include/backgroundthread.h (working copy)
@@ -27,18 +27,13 @@
* BackgroundThreadPool is a low overhead thread pool implementation around BackgroundThread.
*/

+
class AbstractJob
{
-    friend class BackgroundThread;
-
-    bool deleted;
-    bool done;
-
public:
-    AbstractJob() : deleted(false), done(false) {};
+    AbstractJob(){};
     virtual ~AbstractJob(){};
     virtual void operator()() = 0;
-    void Delete() { deleted = true; if(done) delete this;};
};


@@ -155,20 +150,10 @@
                 break;

             job = queue->Pop();
-
-            if(job->deleted)
-            {
-                delete job;
-                continue;
-            }
-
             (*job)();
-            job->done = true;

-            if(job->deleted || ownsJobs)
-            {
+            if(ownsJobs)
                 delete job;
-            }
         }
         return 0;
     };
C Programmer working to learn more about C++.
On Windows 10 64 bit and Windows 11 64 bit.
--
When in doubt, read the CB WiKi FAQ. [url="http://wiki.codeblocks.org"]http://wiki.codeblocks.org[/url]

killerbot

no It was not reverted. And as stated in an other thread, the precompiled header include should be removed (this will not cause a crash, I think, but can lead to 'not building').

MortenMacFly

Quote from: thomas on August 26, 2007, 12:18:04 AM
Martin reverted it though? So... nothing to solve?
No, I didn't revert. I don't revert code I don't understand - and I was under the assumption you had a good reason for your revert...?!
Compiler logging: Settings->Compiler & Debugger->tab "Other"->Compiler logging="Full command line"
C::B Manual: [url="https://www.codeblocks.org/docs/main_codeblocks_en.html"]https://www.codeblocks.org/docs/main_codeblocks_en.html[/url]
C::B FAQ: [url="https://wiki.codeblocks.org/index.php?title=FAQ"]https://wiki.codeblocks.org/index.php?title=FAQ[/url]

stahta01

Quote from: killerbot on August 26, 2007, 08:22:58 AM
no It was not reverted. And as stated in an other thread, the precompiled header include should be removed (this will not cause a crash, I think, but can lead to 'not building').

Builds under windows OK without precompiled header include.

Tim S
C Programmer working to learn more about C++.
On Windows 10 64 bit and Windows 11 64 bit.
--
When in doubt, read the CB WiKi FAQ. [url="http://wiki.codeblocks.org"]http://wiki.codeblocks.org[/url]