News:

The new Release 25.03 is out! You can download binaries for Windows and many major Linux distros here .

Main Menu

wxSmith ArtProvider/Toolbar issue (patch submitted)

Started by rj-away, September 17, 2007, 09:08:09 AM

Previous topic - Next topic

rj-away

I'm not sure if the usual protocol is to provide notice about submitted patches here or not but I recently submitted a patch to fix a non-critical but real bug in some of the handling of ArtProvider stuff for Toolbars. This patch "seemed to work fine for metm".

byo

Thanks for the patch. I haven't had much time to investigate it before but from what I've seen your solution (maybe not only inside wxToolbar but in wxBitmapIconProperty) is correct.

Regards
   BYO

byo

Ok, I've fixed that (little bit different from your). It worked for me but since I don't have debug wxWidges library I can't be sure. Could you test if the fix works ?

BYO

rj-away

Thank you byo, that seems to have solved the core issue with the wxArtProvider stuff.

One side issue, though, is that the #include for <wx/artprov.h> isn't being generated in the resulting cpp code.