directcommands additional output files check bug

[jeroen]

Hi everybody,

there is a bug in directcommands.cpp which causes a crash on my computer when debugging/building (svn5180). I don't know what it completely does but I've got a patch here:

Code Select Expand

diff -Naur ./old/directcommands.cpp ./fixed/directcommands.cpp
--- ./old/directcommands.cpp 2008-08-08 11:09:05.669153800 +0200
+++ ./fixed/directcommands.cpp 2008-08-08 10:47:06.568765600 +0200
@@ -827,12 +827,12 @@
         // let's check the additional output files
         for (size_t x = 0; x < files.GetCount(); ++x)
         {
-            if (files[i].IsEmpty())
+            if (files[x].IsEmpty())
                 continue;

-            Manager::Get()->GetMacrosManager()->ReplaceMacros(files[i]);
+            Manager::Get()->GetMacrosManager()->ReplaceMacros(files[x]);
             time_t addT;
-            depsTimeStamp(files[i].mb_str(), &addT);
+            depsTimeStamp(files[x].mb_str(), &addT);
             // if additional file doesn't exist, we can skip it
             if (!addT)
                 continue;

Hope to see it in the next release.
If this is not the way to report bugs/fixes please tell me.

regards Jeroen

[Jenna]

fixed in svn r5181.

Thanks for pointing this out and the patch.

If this is not the way to report bugs/fixes please tell me.

The best way to report bugs and post patches (so that they can't get lost) is berlios.de:

for bugs: http://developer.berlios.de/bugs/?group_id=5358
and patches: http://developer.berlios.de/patch/?group_id=5358

EDIT:
You will need to create a berlios account, if you not already have one.

[jeroen]

Thanks for the pointers and the nice work on codeblocks