html build log, wrong encoding ??

[killerbot]

Anyone who can confirm the following issue, or who has ideas how to fix ?

Environment : revision of today, linux 32 bit.

In the log window of CB :

/home/lieven/Projects/view_vipnt_buildserver/vipnt/AngleSvd/src/AngleSvd.cpp: In member function 'virtual vipnt::TRAF_ERROR vipnt::CAngleSvdAlgo::Run()':
/home/lieven/Projects/view_vipnt_buildserver/vipnt/AngleSvd/src/AngleSvd.cpp:464: warning: switch missing default case

in in the html log :

/home/lieven/Projects/view_vipnt_buildserver/vipnt/AngleSvd/src/AngleSvd.cpp: In member function ‘virtual vipnt::TRAF_ERROR vipnt::CAngleSvdAlgo::Run()’:
/home/lieven/Projects/view_vipnt_buildserver/vipnt/AngleSvd/src/AngleSvd.cpp:464: warning: switch missing default case

Seems we have issues with the ´  ...

In the html itself (so not shown by browser : firefox), we see :

/home/lieven/Projects/view_vipnt_buildserver/vipnt/AngleSvd/src/AngleSvd.cpp: In member function 'virtual vipnt::TRAF_ERROR vipnt::CAngleSvdAlgo::Run()':<br />

Possible solution : before sending the text to the html file, look for the ´ and especially encode it, or replace all it by "
or '

What do you think ?

[killerbot]

my solution would be :
in compilergcc.cpp : LogMessage

Code Select Expand


        // replace the ´ family by "
wxString Quoted = message;
Quoted.Replace(_("'"), _("\""), true);
Quoted.Replace(_("'"), _("\""), true);
        m_BuildLogContents << Quoted;


In case there are no objections I would commit this tomorrow.